Skip to content

fix: allow Any type for classInput#182

Merged
vincentsarago merged 1 commit into
mainfrom
fix/allow-any-type-for-classInput
Jun 29, 2026
Merged

fix: allow Any type for classInput#182
vincentsarago merged 1 commit into
mainfrom
fix/allow-any-type-for-classInput

Conversation

@vincentsarago

Copy link
Copy Markdown
Member

Args and Kwargs don't have to be of type string for the Class. Without this change, trying to pass something else than a string will raise a pydantic error

@vincentsarago vincentsarago requested a review from alukach June 29, 2026 20:53
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.39%. Comparing base (6eb527a) to head (230632b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   89.39%   89.39%           
=======================================
  Files          29       29           
  Lines        1273     1273           
  Branches      170      170           
=======================================
  Hits         1138     1138           
  Misses         92       92           
  Partials       43       43           
Flag Coverage Δ
unittests 89.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot added the fix label Jun 29, 2026

@alukach alukach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, not sure why it was set to str

@vincentsarago vincentsarago merged commit 56aa3f5 into main Jun 29, 2026
11 checks passed
@vincentsarago vincentsarago deleted the fix/allow-any-type-for-classInput branch June 29, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants