This repository was archived by the owner on Dec 8, 2019. It is now read-only.
Fix the return value in the sort() function to follow the standard#3
Open
educastellano wants to merge 1 commit intodevfacet:masterfrom
Open
Fix the return value in the sort() function to follow the standard#3educastellano wants to merge 1 commit intodevfacet:masterfrom
educastellano wants to merge 1 commit intodevfacet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sort() function that's called after filtering the items was returning a boolean instead of
1,-1or0as it is specified in the standard. It happens to work in some versions of NodeJS and Firefox but not Chrome (the versions I tried at least).