Conversation
madhavilosetty-intel
approved these changes
May 4, 2026
There was a problem hiding this comment.
Pull request overview
Restructures the Helm chart to deploy the Device Management Toolkit “Console” with optional cloud/on-prem overlays, including renaming legacy “mps” chart concepts and gating optional components (Kong, sample Web UI, MPS router) via values.
Changes:
- Renames the chart to
console, updates default values layout, and adds cloud/on-prem overlay values files. - Adds
*.enabledfeature flags for Console/RPS/WebUI/MPS router/Kong and wraps templates accordingly. - Vendors Vault chart dependency (adds
vault-0.32.0.tgz) and addsChart.lock; removeskubernetes/config.json.
Reviewed changes
Copilot reviewed 10 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| kubernetes/config.json | Removes previously committed Docker config (auth headers). |
| charts/values.yaml | Introduces base “console” values and enabled flags; adjusts defaults (e.g., Kong off, Vault UI ClusterIP). |
| charts/values-onprem.yaml | Adds on-prem overlay (headless false; disables webui/mpsrouter/kong). |
| charts/values-cloud.yaml | Adds cloud overlay (headless true; enables webui/mpsrouter/kong; sets Vault UI LB). |
| charts/templates/console.yaml | Renames Service/Deployment from mps→console and updates env vars/secrets wiring. |
| charts/templates/rps.yaml | Wraps RPS resources in rps.enabled. |
| charts/templates/webui.yaml | Wraps Web UI resources in webui.enabled and updates values key usage and backend URLs. |
| charts/templates/mpsrouter.yaml | Wraps MPS router resources in mpsrouter.enabled. |
| charts/templates/kong.yaml | Wraps Kong resources in kong.enabled and updates login backend to Console service. |
| charts/templates/_helpers.tpl | Adds standard Helm helper templates (currently not referenced elsewhere). |
| charts/secrets.yaml | Adds a standalone Secret manifest with placeholder values. |
| charts/charts/vault-0.32.0.tgz | Vendors Vault dependency artifact. |
| charts/Chart.yaml | Renames chart metadata, bumps appVersion, and gates Kong dependency with condition: kong.enabled. |
| charts/Chart.lock | Adds dependency lock file for vendored charts. |
| charts/.helmignore | Adds Helm ignore patterns for packaging. |
Comments suppressed due to low confidence (4)
charts/templates/console.yaml:63
CONSOLE_CONNECTION_STRINGis read from Secretconsole, but the PR’scharts/secrets.yamlstill defines the DB secret asmps. As-is, the Console Deployment will fail to start due to a missing Secret. Align the secret name(s) (either rename the Secret incharts/secrets.yamltoconsoleor update thissecretKeyRef.name).
charts/templates/console.yaml:93CONSOLE_WEB_ADMIN_USER/PASSWORDreference Secretconsoleweb, but the PR’scharts/secrets.yamldefines the credentials secret asmpsweb. This mismatch will cause the Console pod to fail at runtime with a missing Secret. Rename the Secret incharts/secrets.yamltoconsoleweb(or update thesesecretKeyRef.namevalues) so the chart is internally consistent.
charts/templates/rps.yaml:9- Even after renaming MPS to Console elsewhere, this template still configures
RPS_MPS_SERVERto talk tohttp://mps:3000. Since the Service is now namedconsole(seecharts/templates/console.yaml), this will break RPS-to-Console communication. Update the target host/service name to match the new Console Service (and consider templating it via values so it stays consistent if the Service name changes).
charts/templates/kong.yaml:6 charts/templates/kong.yamlis now gated bykong.enabled, but the Ingress backends still unconditionally referencewebui,rps, andmpsrouterServices, while those components are separately gated bywebui.enabled,rps.enabled, andmpsrouter.enabled. If a user enables Kong without enabling one of those components, the install will produce invalid Ingress resources pointing at missing Services. Consider either (a) guarding each path/resource with the corresponding*.enabledflag, or (b) adding a Helmfail/requiredvalidation whenkong.enabledis true but required backends are disabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
device-management-toolkit/console#684