Skip to content

feat(charts): restructure for Console with cloud/on-prem overlays#555

Merged
rsdmike merged 1 commit intomainfrom
helm
May 4, 2026
Merged

feat(charts): restructure for Console with cloud/on-prem overlays#555
rsdmike merged 1 commit intomainfrom
helm

Conversation

@rsdmike
Copy link
Copy Markdown
Member

@rsdmike rsdmike commented May 4, 2026

Copilot AI review requested due to automatic review settings May 4, 2026 21:07
@rsdmike rsdmike enabled auto-merge (squash) May 4, 2026 21:08
@rsdmike rsdmike merged commit 76f642e into main May 4, 2026
4 checks passed
@rsdmike rsdmike deleted the helm branch May 4, 2026 21:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restructures the Helm chart to deploy the Device Management Toolkit “Console” with optional cloud/on-prem overlays, including renaming legacy “mps” chart concepts and gating optional components (Kong, sample Web UI, MPS router) via values.

Changes:

  • Renames the chart to console, updates default values layout, and adds cloud/on-prem overlay values files.
  • Adds *.enabled feature flags for Console/RPS/WebUI/MPS router/Kong and wraps templates accordingly.
  • Vendors Vault chart dependency (adds vault-0.32.0.tgz) and adds Chart.lock; removes kubernetes/config.json.

Reviewed changes

Copilot reviewed 10 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
kubernetes/config.json Removes previously committed Docker config (auth headers).
charts/values.yaml Introduces base “console” values and enabled flags; adjusts defaults (e.g., Kong off, Vault UI ClusterIP).
charts/values-onprem.yaml Adds on-prem overlay (headless false; disables webui/mpsrouter/kong).
charts/values-cloud.yaml Adds cloud overlay (headless true; enables webui/mpsrouter/kong; sets Vault UI LB).
charts/templates/console.yaml Renames Service/Deployment from mps→console and updates env vars/secrets wiring.
charts/templates/rps.yaml Wraps RPS resources in rps.enabled.
charts/templates/webui.yaml Wraps Web UI resources in webui.enabled and updates values key usage and backend URLs.
charts/templates/mpsrouter.yaml Wraps MPS router resources in mpsrouter.enabled.
charts/templates/kong.yaml Wraps Kong resources in kong.enabled and updates login backend to Console service.
charts/templates/_helpers.tpl Adds standard Helm helper templates (currently not referenced elsewhere).
charts/secrets.yaml Adds a standalone Secret manifest with placeholder values.
charts/charts/vault-0.32.0.tgz Vendors Vault dependency artifact.
charts/Chart.yaml Renames chart metadata, bumps appVersion, and gates Kong dependency with condition: kong.enabled.
charts/Chart.lock Adds dependency lock file for vendored charts.
charts/.helmignore Adds Helm ignore patterns for packaging.
Comments suppressed due to low confidence (4)

charts/templates/console.yaml:63

  • CONSOLE_CONNECTION_STRING is read from Secret console, but the PR’s charts/secrets.yaml still defines the DB secret as mps. As-is, the Console Deployment will fail to start due to a missing Secret. Align the secret name(s) (either rename the Secret in charts/secrets.yaml to console or update this secretKeyRef.name).
    charts/templates/console.yaml:93
  • CONSOLE_WEB_ADMIN_USER/PASSWORD reference Secret consoleweb, but the PR’s charts/secrets.yaml defines the credentials secret as mpsweb. This mismatch will cause the Console pod to fail at runtime with a missing Secret. Rename the Secret in charts/secrets.yaml to consoleweb (or update these secretKeyRef.name values) so the chart is internally consistent.
    charts/templates/rps.yaml:9
  • Even after renaming MPS to Console elsewhere, this template still configures RPS_MPS_SERVER to talk to http://mps:3000. Since the Service is now named console (see charts/templates/console.yaml), this will break RPS-to-Console communication. Update the target host/service name to match the new Console Service (and consider templating it via values so it stays consistent if the Service name changes).
    charts/templates/kong.yaml:6
  • charts/templates/kong.yaml is now gated by kong.enabled, but the Ingress backends still unconditionally reference webui, rps, and mpsrouter Services, while those components are separately gated by webui.enabled, rps.enabled, and mpsrouter.enabled. If a user enables Kong without enabling one of those components, the install will produce invalid Ingress resources pointing at missing Services. Consider either (a) guarding each path/resource with the corresponding *.enabled flag, or (b) adding a Helm fail/required validation when kong.enabled is true but required backends are disabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants