Conversation
madhavilosetty-intel
approved these changes
May 4, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the local Docker Compose setup to a new layout centered around the console service, aligning the compose file with a v3-style configuration and removing older service definitions.
Changes:
- Add a new
consoleservice with healthcheck, port mappings, and environment variables. - Update
rpsandmpsrouterconfiguration to integrate with the newconsole-based stack. - Remove the legacy
mpsandconsulservice blocks and clean up formatting/sections.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+18
to
+22
| environment: | ||
| APP_COMMON_NAME: ${MPS_COMMON_NAME} | ||
| DB_URL: postgres://${POSTGRES_USER}:${POSTGRES_PASSWORD}@db:5432/consoledb | ||
| SECRET_ADDR: http://vault:8200 | ||
| SECRET_TOKEN: ${VAULT_TOKEN} |
| networks: | ||
| - openamtnetwork | ||
| environment: | ||
| MPS_CONNECTION_STRING: postgresql://${POSTGRES_USER}:${POSTGRES_PASSWORD}@db:5432/consoledb?sslmode=disable |
Comment on lines
61
to
65
| test: ["CMD", "node", "rps/dist/Healthcheck.js"] | ||
| environment: | ||
| RPS_MPS_SERVER: http://mps:3000 | ||
| environment: | ||
| RPS_MPS_SERVER: http://console:8181 | ||
| RPS_SECRETS_PATH: ${SECRETS_PATH} | ||
| RPS_VAULT_TOKEN: ${VAULT_TOKEN} |
| MPS_CONSUL_PORT: ${CONSUL_PORT} | ||
| volumes: | ||
| - private-volume:/mps-microservice/private | ||
|
|
Comment on lines
170
to
+172
| volumes: | ||
| app-volume: | ||
| private-volume: | ||
| consul-config: | ||
| consul-data: | ||
| networks: | ||
| app-volume: | ||
| private-volume: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
device-management-toolkit/console#684