Architecture doc, mock-fm stub, and integration smoke test#4
Closed
devinoldenburg wants to merge 1 commit into
Closed
Architecture doc, mock-fm stub, and integration smoke test#4devinoldenburg wants to merge 1 commit into
devinoldenburg wants to merge 1 commit into
Conversation
Lore-guided gap: no explicit architecture decision — document CLI/bench/report layers in docs/architecture.md. Ship scripts/mock-fm.sh for FM_BIN pipeline tests on Linux/CI; wire AGENTS/CONTRIBUTING/README and an integration test. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/architecture.md— explicit module map (CLI, benchmark, reports, compare) so agents/contributors do not infer layout from folders alone.scripts/mock-fm.shand documentFM_BINusage in AGENTS.md / CONTRIBUTING.md for off-macOS pipeline testing.test/mock-fm.integration.test.js— quick-profile benchmark smoke with mockfm(43 tests pass)..lore/data/locally.Lore-driven context
Analyzed the repo with Lore (
lore askon architecture/schema/CLI tasks). The main gap wasno_explicit_architecture_decision— addressed withdocs/architecture.md(not ADR fiction).Test plan
npm testnpm run lintFM_BIN=./scripts/mock-fm.sh node bin/fm-bench.js --models system --runs 1 --profile quick --format jsonMade with Cursor