Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 22072311146Details
💛 - Coveralls |
Contributor
|
I´ve checked the code and there are no comments on my side. |
hohwille
approved these changes
Feb 16, 2026
Member
hohwille
left a comment
There was a problem hiding this comment.
@SDallmann thanks for your PR. Nice job 👍
Sorry, it took so long because I first was too busy and then sick.
I left some review comments for improvement.
After that we can merge.
cli/src/main/java/com/devonfw/tools/ide/commandlet/AbstractUpdateCommandlet.java
Outdated
Show resolved
Hide resolved
Member
|
@SDallmann since you are in currently unavailable, I will simply apply the suggestions so I can already merge your PR and it can be included in the release that was postponed for this Thursday. |
hohwille
reviewed
Feb 16, 2026
cli/src/main/java/com/devonfw/tools/ide/commandlet/AbstractUpdateCommandlet.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1699
Implemented changes:
If the input URL isn't valid, the user will be requested to provide the URL again.
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal