Skip to content

#1699 verify input git url#1700

Merged
hohwille merged 9 commits intodevonfw:mainfrom
SDallmann:#1699-verify-input-GitUrl
Feb 16, 2026
Merged

#1699 verify input git url#1700
hohwille merged 9 commits intodevonfw:mainfrom
SDallmann:#1699-verify-input-GitUrl

Conversation

@SDallmann
Copy link
Contributor

This PR fixes #1699

Implemented changes:

  • Added the functionality to verify that the input Git URL is valid, i.e. it start with http, https, ssh or @git.
    If the input URL isn't valid, the user will be requested to provide the URL again.
  • Added unit tests for this functionality.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@hohwille hohwille moved this from 🆕 New to Team Review in IDEasy board Feb 3, 2026
@coveralls
Copy link
Collaborator

coveralls commented Feb 3, 2026

Pull Request Test Coverage Report for Build 22072311146

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 70.465%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/git/GitUrl.java 3 87.72%
com/devonfw/tools/ide/commandlet/AbstractUpdateCommandlet.java 18 83.08%
Totals Coverage Status
Change from base Build 21513109358: 0.02%
Covered Lines: 10492
Relevant Lines: 14305

💛 - Coveralls

@lubska
Copy link
Contributor

lubska commented Feb 6, 2026

I´ve checked the code and there are no comments on my side.

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SDallmann thanks for your PR. Nice job 👍
Sorry, it took so long because I first was too busy and then sick.
I left some review comments for improvement.
After that we can merge.

@github-project-automation github-project-automation bot moved this from Team Review to 👀 In review in IDEasy board Feb 16, 2026
@hohwille hohwille added this to the release:2026.02.001 milestone Feb 16, 2026
@hohwille
Copy link
Member

@SDallmann since you are in currently unavailable, I will simply apply the suggestions so I can already merge your PR and it can be included in the release that was postponed for this Thursday.

@hohwille hohwille self-assigned this Feb 16, 2026
@hohwille hohwille merged commit 90a9be6 into devonfw:main Feb 16, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDEasy board Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Add function to verify that the provided git URL is valid

4 participants

Comments