[PT-2026] Fix images at welcome page and add kcd Porto and DevOps Porto as community sponsors#15914
[PT-2026] Fix images at welcome page and add kcd Porto and DevOps Porto as community sponsors#15914somatorio wants to merge 4 commits into
Conversation
✅ Deploy Preview for devopsdays-web ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hello @somatorio, The parts of this PR that touch only the PT-2026 event are reasonable; however, this PR also modifies the theme, which is a different request altogether. It will need to go through a more rigorous review by the web team, and to be blunt: that might take a while. My strong suggestion: make two PRs. One that gets you the visual result you want using the existing theme, and then another that proposes the theme modification for RFC. Let me know how you want to proceed. |
|
To make that change without the shortcode I would have to duplicate the kcd-porto logo, having it at the assets and a copy at static :/ Unless there is another way and @toshywoshy can point me towards it |
|
Just noticed I could add "style" to the shortcode as well as this could be useful, don't know what you folks think of that though |
|
I prefer not to add a styling to the image block, as it will inhert that depending on where you use it. |
nimbinatus
left a comment
nimbinatus
left a comment
There was a problem hiding this comment.
The main big change I'd like to see here is making the class parameter optional and adding better documentation. The rest is primarily notes.
| <a href="https://community2.cncf.io/events/details/cncf-kcd-porto-presents-kcd-porto-2026-collab-with-devops-days-portugal"><img src="assets/sponsors/k/kcd-porto-logo.png" class="img-fluid mx-auto" /></a> | ||
| <a href="https://devopsporto.com/"><img src="/img/sponsors/devopsporto.png" class="img-fluid mx-auto" /></a> | ||
| <a href="https://community2.cncf.io/events/details/cncf-kcd-porto-presents-kcd-porto-2026-collab-with-devops-days-portugal">{{< img src="/sponsors/k/kcd-porto.png" class="img-fluid mx-auto" alt="Website KCD Porto" >}}</a> | ||
| <a href="https://devopsporto.com/"><img src="/img/sponsors/devopsporto.png" class="img-fluid mx-auto" alt="Website DevOps Porto"/></a> |
There was a problem hiding this comment.
If you're updating the prior line to change to the shortcode, why not here as well?
| @@ -1,5 +1,7 @@ | |||
| # Reference for devopsdays-theme | |||
|
|
|||
There was a problem hiding this comment.
For the future, I get that this probably was auto-cleaned up, but adding all of the lines and changing the table widths on the markdown that doesn't provide substantive change makes PRs like this really hard to get reviewed quickly. And the next time someone else makes a change, if they have different auto-clean settings on their IDE, this will get changed again. Recommend turning those off in the future for repos where a lot of people with different IDE settings are working.
| The above example would create a new menu item called "Volunteer" which linked to `devopsdays/events/YYYY-CITY/volunteer`, and another menu item called "party" which would link to `http://www.google.com` | ||
|
|
||
| The menu items also take an optional parameter of `icon` where you can set the font-awesome icon that will display on small screens. *Note: This feature is currently deprecated, but it won't break anything if you use this setting* Choose at http://fontawesome.io/icons/. Example: | ||
| The menu items also take an optional parameter of `icon` where you can set the font-awesome icon that will display on small screens. _Note: This feature is currently deprecated, but it won't break anything if you use this setting_ Choose at http://fontawesome.io/icons/. Example: |
| @@ -0,0 +1,6 @@ | |||
| {{ $image := resources.Get (.Get "src") }} | |||
| {{ $class := .Get "class" }} | |||
There was a problem hiding this comment.
I'd recommend this being optional, not required. Not everyone uses CSS classes in this repo.
|
|
||
| ### img | ||
|
|
||
| Create a img html tag with an image from the assets |
There was a problem hiding this comment.
| Create a img html tag with an image from the assets | |
| Create an `img` html tag with an image from the assets directory. | |
| This shortcode requires the image source filepath as `src`, any CSS classes you want to add `class`, and alt text for accessibility `alt`. |
Please add more use information. Also, please update this when you make the class parameter optional.
4 participants
Note: This includes a new shortcode to the theme