Fix: manifest_to_docker_images fails as path is not splittable#140
Fix: manifest_to_docker_images fails as path is not splittable#140roytev wants to merge 3 commits intodevopshq:masterfrom
Conversation
|
Hi @allburov can you please take a look? another fix :) |
|
|
||
| artifact["path"], docker_tag = artifact["path"].rsplit("/", 1) | ||
| artifact["name"] = docker_tag | ||
| artifact["path"] = artifact["properties"]["docker.repoName"] |
There was a problem hiding this comment.
I'm not sure how it's saved nowadays, and that all properties exists on all docker images - could you add a false back instead?
The logic would be this one - if rsplit returns two elements - we use old logic, if not - new one.
And please add two tests for that as well, so we know that it works as it used to with old artifacts too
allburov
left a comment
allburov
left a comment
There was a problem hiding this comment.
I'm not sure how it's saved nowadays, and that all properties exists on all docker images - could you add a false back instead?
The logic would be this one - if rsplit returns two elements - we use old logic, if not - new one.
And please add two tests for that as well, so we know that it works as it used to with old artifacts too
2 participants
fixes #139