Skip to content

fix: boot native surreal persistence during app startup#132

Merged
ibourgeois merged 2 commits intomainfrom
codex/fix-131-native-surreal-boot
Mar 27, 2026
Merged

fix: boot native surreal persistence during app startup#132
ibourgeois merged 2 commits intomainfrom
codex/fix-131-native-surreal-boot

Conversation

@ibourgeois
Copy link
Copy Markdown
Contributor

Summary

  • move the native Surreal persistence override into normal Laravel boot instead of the NativePHP window bootstrap hook
  • keep the NativePHP provider focused on window setup only
  • tighten the native runtime regression so it proves the override runs from real application startup

Closes #131

Testing

  • '/Users/ibourgeois/Library/Application Support/Herd/bin/php84' artisan test --compact tests/Feature/NativeRuntimePersistenceTest.php tests/Feature/FortifyAuthenticationTest.php tests/Feature/SurrealSessionDriverTest.php tests/Feature/DatabaseCacheOnSurrealTest.php tests/Feature/SurrealQueueDriverTest.php

Copilot AI review requested due to automatic review settings March 27, 2026 02:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves the NativePHP Surreal persistence override into the standard Laravel service-provider boot cycle so it runs during normal application startup (including packaged app requests), and keeps the NativePHP window bootstrap provider focused on window setup. It also updates the regression test to target the new startup path.

Changes:

  • Invoke NativeRuntimePersistence::configure() from AppServiceProvider::boot() instead of NativeAppServiceProvider::boot().
  • Remove persistence configuration from the NativePHP window bootstrap hook.
  • Update NativeRuntimePersistenceTest to exercise the new provider location.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
app/Providers/AppServiceProvider.php Calls NativeRuntimePersistence::configure() during normal Laravel boot.
app/Providers/NativeAppServiceProvider.php Removes persistence override so this provider focuses on window setup only.
tests/Feature/NativeRuntimePersistenceTest.php Adjusts regression test to align with the new boot location (but currently does so via manual provider boot).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ibourgeois ibourgeois merged commit 8e62b5a into main Mar 27, 2026
2 checks passed
@ibourgeois ibourgeois deleted the codex/fix-131-native-surreal-boot branch March 27, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: apply native surreal persistence during packaged app boot

2 participants