fix: boot native surreal persistence during app startup#132
Merged
ibourgeois merged 2 commits intomainfrom Mar 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves the NativePHP Surreal persistence override into the standard Laravel service-provider boot cycle so it runs during normal application startup (including packaged app requests), and keeps the NativePHP window bootstrap provider focused on window setup. It also updates the regression test to target the new startup path.
Changes:
- Invoke
NativeRuntimePersistence::configure()fromAppServiceProvider::boot()instead ofNativeAppServiceProvider::boot(). - Remove persistence configuration from the NativePHP window bootstrap hook.
- Update
NativeRuntimePersistenceTestto exercise the new provider location.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/Providers/AppServiceProvider.php | Calls NativeRuntimePersistence::configure() during normal Laravel boot. |
| app/Providers/NativeAppServiceProvider.php | Removes persistence override so this provider focuses on window setup only. |
| tests/Feature/NativeRuntimePersistenceTest.php | Adjusts regression test to align with the new boot location (but currently does so via manual provider boot). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #131
Testing
'/Users/ibourgeois/Library/Application Support/Herd/bin/php84' artisan test --compact tests/Feature/NativeRuntimePersistenceTest.php tests/Feature/FortifyAuthenticationTest.php tests/Feature/SurrealSessionDriverTest.php tests/Feature/DatabaseCacheOnSurrealTest.php tests/Feature/SurrealQueueDriverTest.php