feat(meerkat-core): add join filter condition support for links#293

Open

sree-vardhan-reddy-D wants to merge 14 commits into

mainfrom

feat/join-condition-filter

sree-vardhan-reddy-D commented Jul 6, 2026

PR Description

Here's a ready-to-use PR description for this branch, linked to SURFF-1294:

Summary

Add join filter condition support for structured joins (joinPathsV2)
New types: JoinFilterCondition, JoinFilterExpression, JoinFilterOperand, JoinConditionOperator
SQL generation for filter conditions appended to the ON clause via buildPredicate
Supports equals, not_equals, null, not_null, empty, not_empty operators with AND/OR nesting

DevRev

work-item: SURFF-1294

sree-vardhan-reddy-D requested review from itsTalwar, ujaval403, vpbs2 and zaidjan-devrev as code owners

July 6, 2026 06:07

sree-vardhan-reddy-D added 6 commits

July 7, 2026 16:18


          feat(meerkat-core): add join filter condition support for structured …

a427642

…joins


          feat(meerkat-core): add join filter condition support for structured …

59f6864

…joins


          Handle bridge tables (link) appearing multiple times in a join path A…

933f64e

…lias repeated bridge tables (link__1, link__2) to avoid DuckDB ambiguit


          make the alias functions modular

e11c310


          remove unnecessary function quoteKey

41c8b39


          simplyfiy the implementation

c8d9e4c

sree-vardhan-reddy-D force-pushed the feat/join-condition-filter branch from baeb6f4 to c8d9e4c Compare

July 7, 2026 10:49


          links gives An invalid path was detected

4501a1c

sree-vardhan-reddy-D changed the title ~~feat(meerkat-core): add join filter condition support for structured joins~~ feat(meerkat-core): add join filter condition support for links

shriram-devrev reviewed

View reviewed changes

meerkat-core/src/joins/v2/joins.ts Outdated

shriram-devrev reviewed

View reviewed changes

meerkat-core/src/types/cube-types/query.ts Outdated

sree-vardhan-reddy-D added 2 commits

July 8, 2026 11:39


          refactor: reuse existing filter AST infrastructure for join conditions

bb38c05


          refactor: reuse MeerkatQueryFilter for join conditions instead of cus…

8e6db4f

…tom types

github-actions Bot commented Jul 8, 2026

⚠️ Heads-up: This repository will be blocked from any work other than patching.

File meerkat-browser/src/browser-cube-to-sql/browser-cube-to-sql.ts is not allowed to be modified in this patch.
The following vulnerability issues are past SLA:

ISS-331766, overdue 1.0d, sev medium, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-08 06:20 UTC
ISS-331767, overdue 1.0d, sev medium, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-08 06:20 UTC
ISS-335950, overdue 1.0d, sev high, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-08 06:20 UTC

Note that there is significant latency in updating this list. Please reach out on #antifragile if you are in a hurry or have an emergency.


          refactor: simplify generateSqlQueryV2

8ba6473

github-actions Bot commented Jul 8, 2026

⚠️ Heads-up: This repository will be blocked from any work other than patching.

File meerkat-browser/src/browser-cube-to-sql/browser-cube-to-sql.ts is not allowed to be modified in this patch.
The following vulnerability issues are past SLA:

ISS-331766, overdue 1.0d, sev medium, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-08 06:35 UTC
ISS-331767, overdue 1.0d, sev medium, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-08 06:35 UTC
ISS-335950, overdue 1.0d, sev high, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-08 06:35 UTC

Note that there is significant latency in updating this list. Please reach out on #antifragile if you are in a hurry or have an emergency.


          refactor: cleanup the code

7a0f4cc

github-actions Bot commented Jul 8, 2026

⚠️ Heads-up: This repository will be blocked from any work other than patching.

File meerkat-browser/src/browser-cube-to-sql/browser-cube-to-sql.ts is not allowed to be modified in this patch.
The following vulnerability issues are past SLA:

ISS-331766, overdue 1.0d, sev medium, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-08 06:50 UTC
ISS-331767, overdue 1.0d, sev medium, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-08 06:50 UTC
ISS-335950, overdue 1.0d, sev high, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-08 06:50 UTC

Note that there is significant latency in updating this list. Please reach out on #antifragile if you are in a hurry or have an emergency.

shriram-devrev reviewed

View reviewed changes

meerkat-core/src/joins/v2/joins.ts Outdated


          refactor: added isBridge to StructuredJoin

840aecc

github-actions Bot commented Jul 8, 2026

⚠️ Heads-up: This repository will be blocked from any work other than patching.

File meerkat-browser/src/browser-cube-to-sql/browser-cube-to-sql.ts is not allowed to be modified in this patch.
The following vulnerability issues are past SLA:

ISS-331766, overdue 1.0d, sev medium, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-08 11:05 UTC
ISS-331767, overdue 1.0d, sev medium, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-08 11:05 UTC
ISS-335950, overdue 1.0d, sev high, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-08 11:05 UTC
ISS-336523, overdue 1.0d, sev high, owner: shriram.chandirasekaran@devrev.ai, checked: 2026-07-08 11:05 UTC

Note that there is significant latency in updating this list. Please reach out on #antifragile if you are in a hurry or have an emergency.


          bring back links to normal case while checking for Path ambiguity

f0ddfa5

github-actions Bot commented Jul 9, 2026

⚠️ Heads-up: This repository will be blocked from any work other than patching.

File meerkat-browser/src/browser-cube-to-sql/browser-cube-to-sql.ts is not allowed to be modified in this patch.
The following vulnerability issues are past SLA:

ISS-331766, overdue 2.0d, sev medium, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-09 06:35 UTC
ISS-331767, overdue 2.0d, sev medium, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-09 06:35 UTC
ISS-335950, overdue 2.0d, sev high, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-09 06:35 UTC
ISS-336523, overdue 1.0d, sev high, owner: shriram.chandirasekaran@devrev.ai, checked: 2026-07-09 06:35 UTC

Note that there is significant latency in updating this list. Please reach out on #antifragile if you are in a hurry or have an emergency.


          remove throw error for preivously visisted 'graph[from.table]?.[to.ta…

cf9a178

…ble]?.[from.column]'

github-actions Bot commented Jul 9, 2026

⚠️ Heads-up: This repository will be blocked from any work other than patching.

File meerkat-browser/src/browser-cube-to-sql/browser-cube-to-sql.ts is not allowed to be modified in this patch.
The following vulnerability issues are past SLA:

ISS-331766, overdue 2.0d, sev medium, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-09 06:50 UTC
ISS-331767, overdue 2.0d, sev medium, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-09 06:50 UTC
ISS-335950, overdue 2.0d, sev high, owner: sriram.balasubramanian@devrev.ai, checked: 2026-07-09 06:50 UTC
ISS-336523, overdue 1.0d, sev high, owner: shriram.chandirasekaran@devrev.ai, checked: 2026-07-09 06:50 UTC

Note that there is significant latency in updating this list. Please reach out on #antifragile if you are in a hurry or have an emergency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

At least 1 approving review is required to merge this pull request.

Labels

None yet