feat: add managerfactory package for generated register imports#8
Conversation
The register generator template references managerfactory.SharedManagerFactory in the NewRESTFunc type signature. Move this interface definition into apiserver so consumers don't need to define it separately.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 20 minutes and 19 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
pkg/managerfactorywithSharedManagerFactory,ClusterClientAccess, andManagementClientAccessinterfacesgithub.com/devsy-org/apiserver/pkg/managerfactoryin generatedzz_generated.api.register.gofiles (added in fix: resolve import alias collisions and NewRESTFunc signature in generator #6)Without this package, consumers get a build failure when running
deepcopy-genor other generators that parse the generated register files: