fix(desktop): make workspace creation Retry button work after failure - #780
Merged
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe workspace wizard now allows failed workspace launches to be retried despite an existing workspace name conflict, while still rejecting invalid workspace IDs. A Vitest case covers the failure, conflict, and retry sequence. ChangesWorkspace retry flow
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
skevetter
marked this pull request as ready for review
July 27, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Retry button in the workspace creation wizard did nothing when clicked after a failed launch.
handleLaunchbegan with the guardif (resolvedIdInvalid || nameConflict) return. When creation fails, the workspace id has usually already been registered in the$workspacesstore (partial creation), sonameConflictbecomestrueon retry and the handler returns immediately — no spinner, no error, no toast.The guard is correct for the initial launch but is a false positive on retry, since we're deliberately re-creating that same workspace and the name is already locked at the launch step.
handleLaunchnow takes anisRetryflag that skips thenameConflictcheck; the Retry button passestrue, while the initial-launch path is unchanged.Adds a regression test that registers the failed workspace in the store and asserts Retry re-invokes
workspaceUp.Summary by CodeRabbit
Bug Fixes
Tests