Skip to content

fix(desktop): make workspace creation Retry button work after failure - #780

Merged
skevetter merged 1 commit into
mainfrom
orange-sheep
Jul 27, 2026
Merged

fix(desktop): make workspace creation Retry button work after failure#780
skevetter merged 1 commit into
mainfrom
orange-sheep

Conversation

@skevetter

@skevetter skevetter commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

The Retry button in the workspace creation wizard did nothing when clicked after a failed launch.

handleLaunch began with the guard if (resolvedIdInvalid || nameConflict) return. When creation fails, the workspace id has usually already been registered in the $workspaces store (partial creation), so nameConflict becomes true on retry and the handler returns immediately — no spinner, no error, no toast.

The guard is correct for the initial launch but is a false positive on retry, since we're deliberately re-creating that same workspace and the name is already locked at the launch step. handleLaunch now takes an isRetry flag that skips the nameConflict check; the Retry button passes true, while the initial-launch path is unchanged.

Adds a regression test that registers the failed workspace in the store and asserts Retry re-invokes workspaceUp.

Summary by CodeRabbit

  • Bug Fixes

    • Improved workspace launch retry behavior when a workspace with the same name already exists.
    • Users can now retry a failed workspace launch successfully in this scenario.
  • Tests

    • Added coverage for retrying failed launches when an existing workspace entry is present.

@netlify

netlify Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 9089907
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a677349d60b80000830696b

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dae3087d-4e45-49ba-96c5-49d17939259d

📥 Commits

Reviewing files that changed from the base of the PR and between 6858022 and 9089907.

📒 Files selected for processing (2)
  • desktop/src/renderer/src/lib/components/workspace/WorkspaceWizard.svelte
  • desktop/src/renderer/src/lib/components/workspace/WorkspaceWizard.test.ts

📝 Walkthrough

Walkthrough

The workspace wizard now allows failed workspace launches to be retried despite an existing workspace name conflict, while still rejecting invalid workspace IDs. A Vitest case covers the failure, conflict, and retry sequence.

Changes

Workspace retry flow

Layer / File(s) Summary
Retry launch handling
desktop/src/renderer/src/lib/components/workspace/WorkspaceWizard.svelte, desktop/src/renderer/src/lib/components/workspace/WorkspaceWizard.test.ts
handleLaunch accepts a retry flag, the Retry button passes it, and a test verifies retry invokes workspaceUp once when the workspace already exists.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing the workspace creation Retry button after a failed launch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 9089907
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a6773493f432d000964dddd

@skevetter
skevetter marked this pull request as ready for review July 27, 2026 15:42
@skevetter
skevetter merged commit a7d2789 into main Jul 27, 2026
28 checks passed
@skevetter
skevetter deleted the orange-sheep branch July 27, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant