Skip to content

revert(e2e): fix raise timeout for agent-socket cleanup - #787

Merged
skevetter merged 2 commits into
mainfrom
revert-786-frantic-walrus
Jul 27, 2026
Merged

revert(e2e): fix raise timeout for agent-socket cleanup#787
skevetter merged 2 commits into
mainfrom
revert-786-frantic-walrus

Conversation

@skevetter

@skevetter skevetter commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Reverts #786

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability and responsiveness when verifying SSH agent-forwarding socket cleanup after disconnect.
    • Reduced delays in detecting cleanup issues by using more frequent polling and shorter command timeouts.

@netlify

netlify Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit fc3bcf2
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a67ceb551d44f0008769379

@netlify

netlify Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit fc3bcf2
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a67ceb593952000087ed40a

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 304c9b53-52bc-4dd6-b4d0-77e8dd4e3ab8

📥 Commits

Reviewing files that changed from the base of the PR and between da6d641 and fc3bcf2.

📒 Files selected for processing (1)
  • e2e/tests/ssh/agent_forward.go

📝 Walkthrough

Walkthrough

The SSH agent-forwarding cleanup tests now use 5-second command contexts, 30-second overall Eventually timeouts, 500-millisecond polling, and string-only callbacks that ignore command errors.

Changes

SSH agent cleanup tests

Layer / File(s) Summary
Cleanup assertion polling
e2e/tests/ssh/agent_forward.go
Both post-disconnect cleanup assertions use shorter contexts and overall timeouts, poll every 500 milliseconds, and return only command output from f.DevsySSH.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • devsy-org/devsy#434: Adds related SSH agent-forwarding cleanup and lifecycle assertions in the same test file.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is specific and aligned with the main change: reverting the agent-socket cleanup timeout increase in e2e tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@skevetter
skevetter marked this pull request as ready for review July 27, 2026 22:03
@skevetter
skevetter merged commit b374d8a into main Jul 27, 2026
66 checks passed
@skevetter
skevetter deleted the revert-786-frantic-walrus branch July 27, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant