fix(git): parse git clone progress as log messages

[skevetter]

git clone already runs with --progress (added in #590), but its \r-delimited "Receiving objects: NN% (x/y)" frames were logged verbatim, producing a wall of near-duplicate lines for large clones.

progressWriter splits git's output on \r as well as \n (git overwrites its progress line with \r rather than emitting a new one), logs percentage updates thinned to one per 10 points, and passes any other line through unchanged.

Rebased off main directly — no longer stacked on #798, and doesn't depend on its status/Reporter model. Progress is logged directly via pkg/log instead of routed through a shared reporter abstraction, so this can merge independently.

Summary by CodeRabbit

• New Features

  • Improved Git clone progress reporting by displaying meaningful updates at regular intervals.
  • Reduced duplicate and overly frequent progress messages for a cleaner output experience.

• Bug Fixes

  • Preserved informational messages and trailing output during Git operations, including progress updates split across lines.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a buffered git progress writer that parses carriage-return and newline output, suppresses duplicate or intermediate progress frames, forwards retained lines, and integrates the writer into clone stdout and stderr handling with tests.

Changes

Git progress output handling

Layer / File(s)	Summary
Progress writer parsing and validation pkg/git/progress.go, pkg/git/progress_test.go	Progress output is split, tracked per label, thinned at percentage intervals, and tested alongside passthrough lines, duplicate suppression, and trailing-buffer flushing.
Clone command integration pkg/git/repo.go	Clone stdout and stderr are routed through the progress writer, which is closed after execution.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant cloneWith
  participant gitRunner
  participant progressWriter
  participant logWriter
  cloneWith->>progressWriter: create from logWriter
  cloneWith->>gitRunner: run clone with filtered stdout/stderr
  gitRunner->>progressWriter: write git progress and informational output
  progressWriter->>logWriter: forward retained lines
  cloneWith->>progressWriter: close and flush buffered output

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: parsing git clone progress and logging it as messages.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

pkg/git/progress_test.go (1)

34-77: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Assert the progress log cadence, not only forwarding suppression.

These tests cannot detect broken throttling because all progress frames are intentionally excluded from out. Capture progress reports and assert the expected 0%, 10%, …, 100% entries and independent labels.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pkg/git/progress_test.go` around lines 34 - 77, Update
TestProgressWriter_ThinsIntermediatePercentages,
TestProgressWriter_DropsExactDuplicateFrame, and
TestProgressWriter_TracksLabelsIndependently to capture progress reports through
the writer’s progress-report mechanism instead of asserting only that out is
empty. Assert the expected throttled 0%, 10%, through 100% cadence, verify exact
duplicate frames are suppressed, and confirm Receiving objects and Resolving
deltas maintain independent progress state.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/git/progress.go`:
- Around line 30-40: Update progressWriter.Write so a flush failure returns the
number of bytes processed through the current delimiter, not len(p). Track the
delimiter’s index while iterating over p and return its delimiter-inclusive
offset alongside the error; preserve the existing successful return behavior.

In `@pkg/git/repo.go`:
- Around line 265-266: Update the clone flow around newProgressWriter and Run so
pw.Close() is called explicitly after Run, and return its error when the clone
succeeds. Remove the deferred Close that discards the trailing flush failure,
while preserving the clone error when Run fails.

---

Nitpick comments:
In `@pkg/git/progress_test.go`:
- Around line 34-77: Update TestProgressWriter_ThinsIntermediatePercentages,
TestProgressWriter_DropsExactDuplicateFrame, and
TestProgressWriter_TracksLabelsIndependently to capture progress reports through
the writer’s progress-report mechanism instead of asserting only that out is
empty. Assert the expected throttled 0%, 10%, through 100% cadence, verify exact
duplicate frames are suppressed, and confirm Receiving objects and Resolving
deltas maintain independent progress state.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 26d196a9-3f75-47bc-b026-fc9f55a8bedd

📥 Commits

Reviewing files that changed from the base of the PR and between dcb0ace and dff17d6.

📒 Files selected for processing (3)

• pkg/git/progress.go
• pkg/git/progress_test.go
• pkg/git/repo.go

[netlify]

✅ Deploy Preview for devsydev canceled.

Name	Link
🔨 Latest commit	93caac0
🔍 Latest deploy log	https://app.netlify.com/projects/devsydev/deploys/6a6946f8eb52a20008b71ad1

[netlify]

✅ Deploy Preview for images-devsy-sh canceled.

Name	Link
🔨 Latest commit	93caac0
🔍 Latest deploy log	https://app.netlify.com/projects/images-devsy-sh/deploys/6a6946f84098c900088ed18d