Skip to content

fix(agent): stop docker image-pull output from leaking into version log - #802

Merged
skevetter merged 2 commits into
mainfrom
fix/docker-image-pull-noise-in-version-log
Jul 29, 2026
Merged

fix(agent): stop docker image-pull output from leaking into version log#802
skevetter merged 2 commits into
mainfrom
fix/docker-image-pull-noise-in-version-log

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

detectVolumeVersion used CombinedOutput() to run its docker run ... --version probe, which merges the container's stdout with docker's own stderr diagnostics. When the helper image wasn't cached, that stderr carried a full multi-line image-pull transcript, which then got treated as the detected "version" string and interpolated into a single log.Infof call — producing a garbled, multi-line log entry:

upgraded remote agent from Unable to find image 'busybox:latest' locally
latest: Pulling from library/busybox
b05093807bb0: Pulling fs layer
...
Status: Downloaded newer image for busybox:latest to v0.0.0

Output() only captures stdout, so the detected version is just whatever the container's script actually printed.

detectVolumeVersion used CombinedOutput, which merges the probe
container's stdout with docker's own stderr diagnostics. When the
helper image wasn't cached, that stderr carried a full multi-line
image-pull transcript, which then got treated as the detected
"version" string and interpolated into a single log.Infof call --
producing a garbled, multi-line log entry like:

  upgraded remote agent from Unable to find image 'busybox:latest'
  locally
  latest: Pulling from library/busybox
  ...
  Status: Downloaded newer image for busybox:latest to v0.0.0

Output() only captures stdout, so the detected version is just
whatever the container's script actually printed.
@netlify

netlify Bot commented Jul 28, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 62ddfe0
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a696e4260db4100088e4785

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@skevetter, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5eb07e6a-9d24-4434-bc58-fbd95f9e9102

📥 Commits

Reviewing files that changed from the base of the PR and between bc98129 and 62ddfe0.

📒 Files selected for processing (2)
  • pkg/agent/delivery/local_docker.go
  • pkg/agent/delivery/local_docker_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Jul 28, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 62ddfe0
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a696e423b4b0100093d48f1

@skevetter
skevetter marked this pull request as ready for review July 29, 2026 04:36
@skevetter
skevetter merged commit 6bdd232 into main Jul 29, 2026
113 of 115 checks passed
@skevetter
skevetter deleted the fix/docker-image-pull-noise-in-version-log branch July 29, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant