fix(agent): stop docker image-pull output from leaking into version log - #802
Conversation
detectVolumeVersion used CombinedOutput, which merges the probe container's stdout with docker's own stderr diagnostics. When the helper image wasn't cached, that stderr carried a full multi-line image-pull transcript, which then got treated as the detected "version" string and interpolated into a single log.Infof call -- producing a garbled, multi-line log entry like: upgraded remote agent from Unable to find image 'busybox:latest' locally latest: Pulling from library/busybox ... Status: Downloaded newer image for busybox:latest to v0.0.0 Output() only captures stdout, so the detected version is just whatever the container's script actually printed.
✅ Deploy Preview for images-devsy-sh canceled.
|
|
Warning Review limit reached
Next review available in: 19 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for devsydev canceled.
|
detectVolumeVersionusedCombinedOutput()to run itsdocker run ... --versionprobe, which merges the container's stdout with docker's own stderr diagnostics. When the helper image wasn't cached, that stderr carried a full multi-line image-pull transcript, which then got treated as the detected "version" string and interpolated into a singlelog.Infofcall — producing a garbled, multi-line log entry:Output()only captures stdout, so the detected version is just whatever the container's script actually printed.