You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updates workload rule documentation to match marketing standards and includes revised HPA configuration guidance. The misleading network throughput unit comment has been corrected.
✅ 1 resolved✅ Quality: Misleading comment: targetValue "50000000" described as "50 req/s"
📄 README.md:1189📄 README.md:1244📄 README.md:1287📄 sdk/go/devzero/README.md:1189📄 sdk/go/devzero/README.md:1244📄 sdk/go/devzero/README.md:1287
In the HPA metric trigger examples, targetValue is set to "50000000" but the inline comment says // absolute target value (e.g. 50 req/s). The value 50,000,000 does not equal 50 req/s — this will confuse users trying to understand the example. Either fix the comment to reflect what the value actually represents (e.g. 50M milli-units, or whatever the correct interpretation is) or change the value to match the comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the docs for worklaod rule sync with the marketing docs !
Summary by Gitar
namespacePatternfor targeting namespaces by name pattern.HPARuleConfigArgsfields andHPAMetricTriggerArgsusage guidance.EmergencyResponseConfigby removingoomMaxReactionsandoomCooldownSeconds.WorkloadRuleexamples for Go, Node.js, and Python.targetValueunits for network throughput metrics inHPAMetricTriggerArgsdocumentation and examples.This will update automatically on new commits.