update

[Rupam-It]

update on pmetrics type !

---

Summary by Gitar

• Documentation updates:
  • Simplified primaryMetric values from HPA_METRIC_TYPE_MEMORY to memory format in README files
  • Updated examples to reflect the new metric naming convention and clarified targetValue description

_{This will update automatically on new commits.}

[gitar-bot]

💡 Quality: Inconsistent target_value comment in Python example

In the Python example (sdk/go/devzero/README.md line 1244), the comment still says # absolute target value (e.g. 50 req/s) while the TypeScript (line 1189) and Go (line 1287) examples were updated to say // absolute target value (e.g. 50 MB/s of network throughput). The Python comment should be updated to match.

Additionally, the PromQL query in all examples is sum(rate(http_requests_total[2m])) which measures HTTP request rate — not network throughput. The new comment "50 MB/s of network throughput" is misleading when paired with that query. Consider either updating the query to match the comment, or reverting the comment to something query-appropriate like "50 req/s".

Keep comments consistent across all language examples, using a description that matches the PromQL query:

target_value="50",                           # absolute target value (e.g. 50 req/s)

_{Was this helpful? React with 👍 / 👎}

[gitar-bot]

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Simplifies primary metric values and updates documentation examples to reflect the new naming convention. Please address the inconsistent target_value comment in the Python example.

💡 Quality: Inconsistent target_value comment in Python example

📄 sdk/go/devzero/README.md:1244 📄 sdk/go/devzero/README.md:1189 📄 sdk/go/devzero/README.md:1287

In the Python example (sdk/go/devzero/README.md line 1244), the comment still says # absolute target value (e.g. 50 req/s) while the TypeScript (line 1189) and Go (line 1287) examples were updated to say // absolute target value (e.g. 50 MB/s of network throughput). The Python comment should be updated to match.

Additionally, the PromQL query in all examples is sum(rate(http_requests_total[2m])) which measures HTTP request rate — not network throughput. The new comment "50 MB/s of network throughput" is misleading when paired with that query. Consider either updating the query to match the comment, or reverting the comment to something query-appropriate like "50 req/s".

Keep comments consistent across all language examples, using a description that matches the PromQL query

target_value="50",                           # absolute target value (e.g. 50 req/s)

🤖 Prompt for agents

Code Review: Simplifies primary metric values and updates documentation examples to reflect the new naming convention. Please address the inconsistent target_value comment in the Python example.

1. 💡 Quality: Inconsistent target_value comment in Python example
   Files: sdk/go/devzero/README.md:1244, sdk/go/devzero/README.md:1189, sdk/go/devzero/README.md:1287

   In the Python example (sdk/go/devzero/README.md line 1244), the comment still says `# absolute target value (e.g. 50 req/s)` while the TypeScript (line 1189) and Go (line 1287) examples were updated to say `// absolute target value (e.g. 50 MB/s of network throughput)`. The Python comment should be updated to match.
   
   Additionally, the PromQL query in all examples is `sum(rate(http_requests_total[2m]))` which measures HTTP request rate — not network throughput. The new comment "50 MB/s of network throughput" is misleading when paired with that query. Consider either updating the query to match the comment, or reverting the comment to something query-appropriate like "50 req/s".

   Fix (Keep comments consistent across all language examples, using a description that matches the PromQL query):
   target_value="50",                           # absolute target value (e.g. 50 req/s)

_{Was this helpful? React with 👍 / 👎 | Gitar}