Speed up screen transitions and fix local builds on JDK 25#53
Merged
Conversation
Stack transitions felt sluggish: react-native-screens hardcodes Android slide animations to config_mediumAnimTime (400ms) and ignores react-navigation's animationDuration on Android. Override the four rns_slide_* anim resources in the app module (resource merging beats the library's copies) to run at 150ms. Also fix `bun run android` failing at configureCMake on JDK 25: AGP's forked prefab CLI triggers the JEP 472 restricted-method warning via JNA, and AGP treats any unrecognized prefab stderr as fatal. Set JAVA_TOOL_OPTIONS=--enable-native-access=ALL-UNNAMED in mise.toml's [env] — AGP whitelists the resulting "Picked up" line — until the upstream fix (b/469503601) ships in an AGP release. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config_mediumAnimTimeand ignores react-navigation'sanimationDurationon Android, so the fourrns_slide_*anim XMLs are overridden in the app module via Android resource merging. A pointer comment inRootNavigator.tsxlinks the JS config to the XMLs.bun run androidfailing atconfigureCMakeDebugon JDK 25: AGP forks the prefab CLI, whose bundled JNA triggers the JEP 472 restricted-method warning on stderr, and AGP treats any unrecognized prefab stderr line as fatal.JAVA_TOOL_OPTIONS=--enable-native-access=ALL-UNNAMEDin mise.toml's[env]silences the warning in all forked JVMs; AGP explicitly whitelists the resulting "Picked up JAVA_TOOL_OPTIONS" line. Can be removed once the upstream AGP fix (b/469503601) ships in a release.Verification
:app:mergeDebugResourcesconfirms the app-module anim resources win the merge over the library copies../gradlew assembleDebugpasses locally on JDK 25 (previously failed at CMake configure).🤖 Generated with Claude Code