Allow for disabling repository configuration#138
Merged
dfarrell07 merged 1 commit intodfarrell07:masterfrom Mar 17, 2017
Merged
Allow for disabling repository configuration#138dfarrell07 merged 1 commit intodfarrell07:masterfrom
dfarrell07 merged 1 commit intodfarrell07:masterfrom
Conversation
This change moves the repository configuration to it's own class so it can be included externally and excludeded if necessary. As part of this change, the inclusion of rspec-puppet-facts was done to simplify testing support os configurations. See https://github.com/mcanevet/rspec-puppet-facts for details on how to work with rspec-puppet-facts. By default it uses the metadata.json for the supported operating systems. Since 14.04 is not a supported configuration based on the failure in ::opendaylight, this has also been updated to reference 16.04 as a supported version.
Owner
|
This is great refactoring, thanks! The inline docs and tests look perfect. Would be good to add docs for the new param in the README. +1 on updating that Ubuntu version in metadata.json, I had a TODO to scrub for old versions with that one in mind. This does part of #136, and generally cleans up the related logic. It I think the easiest way to resolve the conflict between the two is to merge this larger change and then expose the rpm_repo_enabled param and add rpm_baseurl param as #136 does (edit: if we want to go that way, looking at the original issue #135 it seems like this change may be what was really desired). This passes |
This was referenced Mar 17, 2017
|
@dfarrell07 Hi, Is it possible to create a new release with this PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves the repository configuration to it's own class so it
can be included externally and excludeded if necessary. As part of this
change, the inclusion of rspec-puppet-facts was done to simplify testing
support os configurations.
See https://github.com/mcanevet/rspec-puppet-facts for details on how to
work with rspec-puppet-facts. By default it uses the metadata.json for
the supported operating systems. Since 14.04 is not a supported
configuration based on the failure in ::opendaylight, this has also been
updated to reference 16.04 as a supported version.