Conversation
added 8 commits
October 5, 2022 11:59
cha0sg0d
commented
Oct 5, 2022
| <StyledShowPercent> | ||
| <span>{value}%</span> | ||
| <span> | ||
| {/* <span>{value}%</span> */} |
Author
There was a problem hiding this comment.
Suggested change
| {/* <span>{value}%</span> */} |
cha0sg0d
commented
Oct 6, 2022
| throw new Error('game has ended'); | ||
| } | ||
| const planet = this.entityStore.getPlanetWithId(locationId); | ||
| console.log(`basic withdraw planet`, planet); |
Author
There was a problem hiding this comment.
Suggested change
| console.log(`basic withdraw planet`, planet); |
cha0sg0d
commented
Oct 6, 2022
| locationIds: planets.map((p) => p.locationId), | ||
| }; | ||
|
|
||
| console.log(`clean args`, Promise.resolve([[...ids]])); |
Author
There was a problem hiding this comment.
Suggested change
| console.log(`clean args`, Promise.resolve([[...ids]])); |
cha0sg0d
commented
Oct 6, 2022
|
|
||
| let upgradeRow = null; | ||
| if (!p?.destroyed && owned) { | ||
| if (!p?.destroyed && owned && p?.planetType == PlanetType.PLANET) { |
Author
There was a problem hiding this comment.
Suggested change
| if (!p?.destroyed && owned && p?.planetType == PlanetType.PLANET) { | |
| if (!p?.destroyed && owned && p?.planetType === PlanetType.PLANET) { |
cha0sg0d
commented
Oct 6, 2022
cha0sg0d
commented
Oct 6, 2022
| await conquerUnownedPlanet(world, world.user1Core, SPAWN_PLANET_1, LVL1_ASTEROID_NEBULA); | ||
| await conquerUnownedPlanet(world, world.user1Core, SPAWN_PLANET_1, LVL1_ASTEROID_DEEP_SPACE); | ||
|
|
||
| // await feedSilverToCap(world, world.user1Core, LVL1_ASTEROID_1, LVL3_SPACETIME_2); |
Author
There was a problem hiding this comment.
Suggested change
| // await feedSilverToCap(world, world.user1Core, LVL1_ASTEROID_1, LVL3_SPACETIME_2); |
cha0sg0d
commented
Oct 6, 2022
| claimedShips: rawPlayer.claimedShips, | ||
| finalRank: rawPlayer.finalRank.toNumber(), | ||
| claimedReward: rawPlayer.claimedReward, | ||
| silver: silver, |
Author
There was a problem hiding this comment.
Silver is a synthetic field on the Player type in client, maybe we should change that
cha0sg0d
commented
Oct 6, 2022
| lastClaimTimestamp: number; | ||
| score: number; | ||
|
|
||
| silver: number; |
Author
There was a problem hiding this comment.
Should silver be added on client but not contracts as a property of player?
cha0sg0d
commented
Oct 6, 2022
| disabled={planet.isHomePlanet || disabled} | ||
| > | ||
| {/* <TooltipTrigger name={TooltipName.Abandon}> */} | ||
| {extracting ? 'Extracting' : `Extract all (${Math.floor(silver)}) silver`} |
Author
There was a problem hiding this comment.
Suggested change
| {extracting ? 'Extracting' : `Extract all (${Math.floor(silver)}) silver`} | |
| {extracting ? 'Extracting' : `Extract (${Math.floor(silver)}) silver`} |
I think we should change this so Extract All can refer to extracting silver from multiple planets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features: