Updates to accessibility panel (shinyGovstyle)#132
Open
DYING-478 wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 63.72% 65.02% +1.29%
==========================================
Files 15 15
Lines 1293 1341 +48
==========================================
+ Hits 824 872 +48
Misses 469 469 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| expect_equal( | ||
| paste(output$children[[1]]), | ||
| "<h1>Accessibility statement for DfE Shiny template</h1>" | ||
| "<h1 class=\"govuk-heading-xl\" id=\"accessibility_statement_for_dfe_shiny_template\">Accessibility statement for DfE Shiny template</h1>" |
| expect_equal( | ||
| paste(output$children[[3]]), | ||
| "<h2>How you should be able to use this website</h2>" | ||
| "<h2 class=\"govuk-heading-l\" id=\"how_you_should_be_able_to_use_this_website\">How you should be able to use this website</h2>" |
| expect_equal( | ||
| paste(output$children[[8]]), | ||
| "<h2>How accessible this website is</h2>" | ||
| "<h2 class=\"govuk-heading-l\" id=\"how_accessible_this_website_is\">How accessible this website is</h2>" |
| expect_equal( | ||
| paste(output$children[[10]]), | ||
| "<h2>Feedback and contact information</h2>" | ||
| "<h2 class=\"govuk-heading-l\" id=\"feedback_and_contact_information\">Feedback and contact information</h2>" |
| expect_equal( | ||
| paste(output$children[[17]]), | ||
| "<h2>Technical information about this website's accessibility</h2>" | ||
| "<h2 class=\"govuk-heading-l\" id=\"technical_information_about_this_websites_accessibility\">Technical information about this website's accessibility</h2>" |
| expect_equal( | ||
| paste(output$children[[23]]), | ||
| "<h2>How we tested this website</h2>" | ||
| "<h2 class=\"govuk-heading-l\" id=\"how_we_tested_this_website\">How we tested this website</h2>" |
| expect_equal( | ||
| paste(output$children[[28]]), | ||
| "<h2>What we're doing to improve accessibility</h2>" | ||
| "<h2 class=\"govuk-heading-l\" id=\"what_were_doing_to_improve_accessibility\">What we're doing to improve accessibility</h2>" |
| expect_equal( | ||
| paste(output$children[[31]]), | ||
| "<h2>Preparation of this accessibility statement</h2>" | ||
| "<h2 class=\"govuk-heading-l\" id=\"preparation_of_this_accessibility_statement\">Preparation of this accessibility statement</h2>" |
rmbielby
requested changes
May 1, 2026
| "We know some parts of this website are not fully accessible:" | ||
| ), | ||
| shiny::tags$div(tags$ol( | ||
| tagList(lapply(non_accessible_components, shiny::tags$li)) |
Contributor
There was a problem hiding this comment.
Please can you switch this to use gov_list(..., style = "number"). It should be a simplification of the code as gov_list() just takes a vector anyway, so you can remove the lapply() bit.
| href = "mailto:explore.statistics@education.gov.uk", | ||
| "explore.statistics@education.gov.uk" | ||
| shinyGovstyle::gov_list( | ||
| list( |
Contributor
There was a problem hiding this comment.
Seem to remember this should be c() rather mthan list()?
Contributor
There was a problem hiding this comment.
As above, please can you switch this to use gov_list(..., style = "number"). It should be a simplification of the code as gov_list() just takes a vector anyway, so you can remove the lapply() bit.
| shiny::tags$p( | ||
| shiny::tags$div( | ||
| shinyGovstyle::gov_list( | ||
| list( |
Contributor
There was a problem hiding this comment.
Again, think this should be c(...) rather than list()? Doesn't look like it's displaying it properly when I run it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The R code for the accessibility panel within the 'dfeshiny' repository is going through an update similar to the support panel, where the new shinyGovstyle format is being used to replace the original version. There are currently updates to the header, text, bullets and numbering being entered. This is however subject to ensuring that all UI tests pass. More commits to follow.