Skip to content

cookies.R update#133

Open
DYING-478 wants to merge 3 commits into
mainfrom
cookies_update
Open

cookies.R update#133
DYING-478 wants to merge 3 commits into
mainfrom
cookies_update

Conversation

@DYING-478
Copy link
Copy Markdown
Contributor

Update to cookies.R script to implement new shinyGovstyle functions to replace the old shiny::tags functions where possible. More commits to follow.

@DYING-478 DYING-478 self-assigned this Apr 29, 2026
@DYING-478 DYING-478 requested a review from rmbielby April 29, 2026 14:35
@DYING-478 DYING-478 changed the title shinyGovstyle update cookies.R update Apr 29, 2026
expect_equal(
paste(output$children[[13]]),
"<h2>Change your cookie settings</h2>"
"<h2 class=\"govuk-heading-l\" id=\"change_your_cookie_settings\">Change your cookie settings</h2>"
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.24%. Comparing base (5e8c889) to head (140da32).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   63.72%   64.24%   +0.51%     
==========================================
  Files          15       15              
  Lines        1293     1306      +13     
==========================================
+ Hits          824      839      +15     
+ Misses        469      467       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e8c889...140da32. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants