Skip to content

Normalize supervisor prediction-mismatch failure naming across active code paths #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfeen87 merged 1 commit into from
Apr 11, 2026
Merged

Normalize supervisor prediction-mismatch failure naming across active code paths #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/supervisor/redundant_supervisor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class RedundantSupervisor {
CRITICAL_ROLLBACK_FAIL,
CRITICAL_NO_ROLLBACK,
PRIMARY_CHANNEL_LOCKUP,
MISMATED_PREDICTION
MISMATCHED_PREDICTION
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming an enum constant in a public header is a source-breaking API change for downstream users that may still reference the misspelled name. Consider keeping MISMATED_PREDICTION as a deprecated alias to MISMATCHED_PREDICTION (same underlying value) so existing code continues to compile while the canonical spelling is used for logging/metrics.

Suggested change
MISMATCHED_PREDICTION
MISMATCHED_PREDICTION,
[[deprecated("Use MISMATCHED_PREDICTION")]] MISMATED_PREDICTION =
MISMATCHED_PREDICTION

Copilot uses AI. Check for mistakes.
};

void init();
Expand Down
4 changes: 2 additions & 2 deletions src/supervisor/supervisor_failure_strings.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ inline const char* supervisor_failure_reason_string(
return "CRITICAL_NO_ROLLBACK";
case RedundantSupervisor::FailureMode::PRIMARY_CHANNEL_LOCKUP:
return "PRIMARY_CHANNEL_LOCKUP";
case RedundantSupervisor::FailureMode::MISMATED_PREDICTION:
return "MISMATED_PREDICTION";
case RedundantSupervisor::FailureMode::MISMATCHED_PREDICTION:
return "MISMATCHED_PREDICTION";
default:
return "UNKNOWN";
}
Expand Down
Loading