ICRC-153: Standardizing Privileged Freeze & Unfreeze Controls#157
Open
ICRC-153: Standardizing Privileged Freeze & Unfreeze Controls#157
Conversation
bogwar
changed the title
bogwar
changed the title
…ix typos - Replace `tx.op` with `tx.mthd` as method discriminator (ICRC-3 alignment) - Fix btype values to match ICRC-123: `123freezeaccount` not `123freeze_account` (same for unfreezeaccount, freezeprincipal, unfreezeprincipal) - Fix typo: `iicrc153_unfreeze_account` → `icrc153_unfreeze_account` - Fix typo: `rsults` → `results`, wrong btype `122freeze_account` → `123freezeaccount` Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…on-wins semantics The Effective Freeze Model section previously described a compositional OR rule, which contradicted ICRC-123's latest-action-wins semantics. Updated to use block-index comparison: the most recent freeze/unfreeze action affecting an account (at either account or principal level) determines its effective status. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Unfreeze calls must succeed even when the target is not frozen at that level, because under ICRC-123 latest-action-wins, a principal unfreeze can lift account-level freezes. Removed NotFrozen from both UnfreezeAccountError and UnfreezePrincipalError variants. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces ICRC-523, a standard API for freezing and unfreezing accounts and principals. It defines four privileged methods, canonical tx mapping, and use of the block kinds from ICRC-123. The standard provides auditors, wallets, and integrators with a consistent way to determine whether funds are frozen and to attribute freezes/unfreezes to authorized actors.