infra(theme): add mobile theme toggle and default to system color scheme#156
Merged
Conversation
- Add custom Header.astro that renders ThemeSelect on mobile (outside the sl-hidden md:sl-flex right-group, which is desktop-only) - Default theme to prefers-color-scheme instead of hardcoded light in both ThemeProvider.astro and ThemeSelect.astro; stored preference still takes precedence on return visits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Header.astro. The toggle was only in thesl-hidden md:sl-flexright-group (desktop-only); a mobile-only copy is now rendered before it usingmd:sl-hidden.lightto the visitor'sprefers-color-schemein bothThemeProvider.astro(FOUC-safe inline script) andThemeSelect.astro(toggle logic). A stored user preference still takes priority on return visits.Sync recommendation
hand-written