Skip to content

chore: update rust to 1.88.0#6045

Merged
kpop-dfinity merged 21 commits intomasterfrom
kpop/rust_1_88
Aug 5, 2025
Merged

chore: update rust to 1.88.0#6045
kpop-dfinity merged 21 commits intomasterfrom
kpop/rust_1_88

Conversation

@kpop-dfinity
Copy link
Contributor

@kpop-dfinity kpop-dfinity commented Jul 24, 2025 •
edited
Loading

Changes

  1. Removed long deprecated rls component, since it's been removed from rust in 1.87.0
  2. disabled uninlined_format_args check - otherwise I would have to change essentially every file in the repo in this PR... - note that the lint has been moved back to pedantic in the cargo clippy, so the problem will eventually go away, but it is still an issue in this version of rust (1.88.0). See also uninlined_format_args should have stayed in pedantic rust-lang/rust-clippy#15151
  3. Explicitly ignored result_large_err warnings - I'll leave it up to the code owners whether/how to fix the warnings
  4. Modified the backtrace message in rs/execution_environment/tests/backtraces.rs
  5. Bumped max compressed wasm size of some nns canisters from 1.5MB to 1.6MB in file_size_check tests
  6. Fixed io_other_error warnings
  7. Fixed iter_kv_map warnings
  8. Fixed manual_contains warnings
  9. Fixed some other, rarely occurring, clippy warnings

Benchmarks updates

//rs/ledger_suite/icrc1/ledger:canbench_u256

Only significant changes:

status name calls ins ins Δ% HI HI Δ% SMI SMI Δ%
+ bench_icrc1_transfers::post_upgrade 1 365.33M +3.75% 71 0.00% 0 0.00%
+ bench_icrc1_transfers::upgrade 1 516.12M +3.17% 200 0.00% 128 0.00%

ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change

//rs/ledger_suite/icrc1/ledger:canbench_u64

Only significant changes:

status name calls ins ins Δ% HI HI Δ% SMI SMI Δ%
+ bench_icrc1_transfers::icrc2_approve 1 18.44B -0.22% 29 +16.00% 128 0.00%
- bench_icrc1_transfers::icrc1_transfer 1 12.24B -0.50% 31 -8.82% 0 0.00%
- bench_icrc1_transfers::icrc2_transfer_from 1 20.57B -0.54% 3 -25.00% 0 0.00%

ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change

//rs/nns/governance:governance-canbench

Only significant changes:

status name calls ins ins Δ% HI HI Δ% SMI SMI Δ%
+ add_neuron_inactive_maximum 64.86M +5.79% 0 0.00% 0 0.00%
+ add_neuron_active_maximum_stable 64.86M +5.79% 0 0.00% 0 0.00%
- list_neurons_stable 63.04M -5.65% 9 0.00% 0 0.00%
- list_neurons_by_subaccount_stable 62.12M -5.67% 5 0.00% 0 0.00%
- range_neurons_performance 51.56M -6.28% 0 0.00% 0 0.00%

ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

Run URL: https://github.com/dfinity/ic/actions/runs/16491669432

New container image: sha256:4e413cc86bac97c7077a9c7857b7ba1ab2e2c8104697f863585ad0ce70aab41f
New container tag: 81b0a98486c17991e211deda54c717bfff6427ff14924bf746d5f8fd6cfb9179

@kpop-dfinity kpop-dfinity added the CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 label Jul 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

Run URL: https://github.com/dfinity/ic/actions/runs/16492087374

New container image: sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
New container tag: 16e06bf3c56bdcc50674a64be074337acee526d41ac785780ae4a9835a6a637b

@kpop-dfinity kpop-dfinity changed the title chore chore: update rust to 1.88.0 Jul 24, 2025
@github-actions github-actions bot added the chore label Jul 24, 2025
kpop-dfinity and others added 9 commits July 25, 2025 08:09
@kpop-dfinity
1.88
adf4d3a
@kpop-dfinity
Updating container image to sha256:4e413cc86bac97c7077a9c7857b7ba1ab2…
a20b7b7 
…e2c8104697f863585ad0ce70aab41f

Image tag: 81b0a98486c17991e211deda54c717bfff6427ff14924bf746d5f8fd6cfb9179
@kpop-dfinity
rm rls
ccebc71
@kpop-dfinity
Updating container image to sha256:a5edec0ae2b045ef86bc957f9a3155a360…
0b2570e 
…edc2a273a700eabd0670dc489d809c

Image tag: 16e06bf3c56bdcc50674a64be074337acee526d41ac785780ae4a9835a6a637b
@kpop-dfinity
clippy
91a68ed
@kpop-dfinity
more clippy
8918b95
@kpop-dfinity
.
df8b40e
@kpop-dfinity
more clippy
0557ca7
@kpop-dfinity
test?
6267318
IDX GitHub Automation and others added 2 commits July 25, 2025 08:17
Automatically updated Cargo*.lock
c7e8078
@kpop-dfinity
* Ignore clippy::uninlined_format_args
cc16f4e 
* Fix
  `//rs/execution_environment:execution_environment_misc_integration_tests/backtraces_test`
  tests
* Fix `//publish/canisters:sns-governance-canister.wasm.gz_size_check`
  test
* Update benchmark reults
@kpop-dfinity kpop-dfinity marked this pull request as ready for review July 25, 2025 15:45
@kpop-dfinity kpop-dfinity requested review from a team as code owners July 25, 2025 15:45
@kpop-dfinity kpop-dfinity requested a review from a team July 25, 2025 15:45
mbjorkqvist
mbjorkqvist approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@mbjorkqvist mbjorkqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @kpop-dfinity, the FI changes LGTM! The overview table of canbench changes is very helpful!

@kpop-dfinity kpop-dfinity dismissed github-actions[bot]’s stale review July 28, 2025 08:12

No canister behavior changes.

daniel-wong-dfinity-org
daniel-wong-dfinity-org reviewed Jul 28, 2025
View reviewed changes
randombit
randombit approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@randombit randombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crypto lgtm

tojot-dfinity
tojot-dfinity reviewed Jul 28, 2025
View reviewed changes
Copy link

@tojot-dfinity tojot-dfinity left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have probably added an explicit comment whenever added #[allow(clippy::result_large_err)], but I'm almost the last to approve, so won't block on that.

LGTM for Utopia

@kpop-dfinity kpop-dfinity added this pull request to the merge queue Aug 5, 2025
Merged via the queue into master with commit a4c1c9b Aug 5, 2025
44 of 45 checks passed
@kpop-dfinity kpop-dfinity deleted the kpop/rust_1_88 branch August 5, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schneiderstefan schneiderstefan schneiderstefan approved these changes

@mihailjianu1 mihailjianu1 mihailjianu1 approved these changes

@blind-oracle blind-oracle blind-oracle approved these changes

@Bownairo Bownairo Bownairo approved these changes

@basvandijk basvandijk basvandijk approved these changes

@mraszyk mraszyk mraszyk approved these changes

@randombit randombit randombit approved these changes

@tojot-dfinity tojot-dfinity tojot-dfinity approved these changes

@mbjorkqvist mbjorkqvist mbjorkqvist approved these changes

@daniel-wong-dfinity-org daniel-wong-dfinity-org daniel-wong-dfinity-org approved these changes

@gregorydemay gregorydemay gregorydemay approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

+3 more reviewers

@dsarlis dsarlis dsarlis approved these changes

@Sawchord Sawchord Sawchord approved these changes

@altkdf altkdf altkdf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

@boundary-node chore CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 @consensus @cross-chain-team @crypto-team @execution @finint @formal-models @governance-team @ic-interface-owners @ic-message-routing-owners @idx @node @pocket-ic @research @utopia

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.