feat(asset-canister): sync plugin#28
Draft
lwshang wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to
sync_pluginwithout changing the canister wasm.Context
This swaps the asset-canister recipe's sync step from the built-in
type: assetsmechanism totype: plugin, without changing the canister wasm — it remains the legacy dfxassetstoragecanister. The goal is to ease the upgrade path for existing asset-canister users oncetype: assetssync is dropped in the upcoming icp-cli release: their canister stays the same, only the sync mechanism changes.The plugin wasm is pinned to a pre-release hosted on the certified-assets repo:
https://github.com/dfinity/certified-assets/releases/download/migration-v2.2.0-209d688/sync_plugin.wasm297c2ef05680d47ac70688d6cebed9bc3a41b2302f400739f894f4f413e6a5eeThat plugin is built from the
migrationbranch ofdfinity/certified-assets, a permanently separate branch (never merged intomain) dedicated to producing a sync plugin that targets the legacy assetstorage canister and reads.ic-assets.json5config:The
v2.2.0in the tag tracks this recipe version (current latest isasset-canister-v2.1.0); the-209d688suffix pins the exact commit the wasm was built from. Future recipe bumps will get a matchingmigration-vX.Y.Z-<hash>release.