feat: add http gateway support #233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR implements HTTP gateway support for PocketIC instances by introducing "live" mode functionality. This allows automated time progression and the ability to test HTTP canisters through an HTTP gateway instead of only the PIC actor interface.
Changes:
- Added
makeLive()andstopLive()methods to PocketIC to enable/disable auto progress and HTTP gateway - Created a new HTTP example demonstrating the live mode functionality
- Updated the Todo example to showcase live mode usage with agent-js
Reviewed changes
Copilot reviewed 24 out of 26 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/pic/src/pocket-ic.ts | Added makeLive() and stopLive() methods with HTTP gateway port tracking |
| packages/pic/src/pocket-ic-client.ts | Implemented HTTP gateway and auto-progress client methods |
| packages/pic/src/pocket-ic-client-types.ts | Added type definitions for live mode requests/responses |
| packages/pic/src/http2-client.ts | Enhanced response handling for boolean returns and empty bodies |
| examples/http/* | New example demonstrating HTTP canister testing in live mode |
| examples/todo/tests/src/live-todo.spec.ts | New test demonstrating live mode with agent-js |
| dfx.json | Updated dfx version and added http canister configuration |
| package.json | Updated pnpm version and added http example test scripts |
| Cargo.toml | Added http example to workspace members |
| .node-version | Updated Node.js version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for pocket ic "live" mode. This will enable auto progress and run an HTTP Gateway.