Skip to content

[#1006][FIX] Add type validation in custom attribute parser to preven… #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ParadiesSau wants to merge 1 commit into
base: develop
Choose a base branch
from
+34 −16
Open

[#1006][FIX] Add type validation in custom attribute parser to preven… #1008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 34 additions & 16 deletions source/app/datamgmt/manage/manage_attribute_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,47 +238,65 @@ def validate_attribute(attribute):
except Exception as e:
return None, [str(e)]

for tab in data:
for tab in data:
# Check if the tab content is actually a dictionary
if not isinstance(data[tab], dict):
logs.append(f"Tab '{tab}' is invalid. It must contain a dictionary of fields.")
continue

for field in data[tab]:
if not data[tab][field].get('type'):
_field_content = data[tab][field]

# Check if field content is a dictionary before accessing .get()
if not isinstance(_field_content, dict):
logs.append(f"Field '{field}' in tab '{tab}' is invalid. Expected an object.")
continue

if not _field_content.get('type'):
logs.append(f'{tab}::{field} is missing mandatory "type" tag')
continue

field_type = data[tab][field].get('type')
field_type = _field_content.get('type')

if field_type in ['input_string', 'input_textfield', 'input_checkbox', 'input_select',
'input_date', 'input_datetime']:
if data[tab][field].get('mandatory') is None:

if _field_content.get('mandatory') is None:
logs.append(f'{tab} -> {field} of type {field_type} is missing mandatory "mandatory" tag')

elif not isinstance(data[tab][field].get('mandatory'), bool):
elif not isinstance(_field_content.get('mandatory'), bool):
logs.append(f'{tab} -> {field} -> "mandatory" expects a value of type bool, '
f'but got {type(data[tab][field].get("mandatory"))}')
f'but got {type(_field_content.get("mandatory")).__name__}')

if data[tab][field].get('value') is None:
if _field_content.get('value') is None:
logs.append(f'{tab} -> {field} of type {field_type} is missing mandatory "value" tag')

if field_type == 'input_checkbox' and not isinstance(data[tab][field].get('value'), bool):
if field_type == 'input_checkbox' and not isinstance(_field_content.get('value'), bool):
logs.append(f'{tab} -> {field} of type {field_type} expects a value of type bool, '
f'but got {type(data[tab][field]["value"])}')
f'but got {type(_field_content.get("value")).__name__}')

if field_type in ['input_string', 'input_textfield', 'input_date', 'input_datetime']:
if not isinstance(data[tab][field].get('value'), str):
if not isinstance(_field_content.get('value'), str):
logs.append(f'{tab} -> {field} of type {field_type} expects a value of type str, '
f'but got {type(data[tab][field]["value"])}')
f'but got {type(_field_content.get("value")).__name__}')

if field_type == 'input_select':
if data[tab][field].get('options') is None:
if _field_content.get('options') is None:
logs.append(f'{tab} -> {field} of type {field_type} is missing mandatory "options" tag')
continue

if not isinstance(data[tab][field].get('options'), list):
if not isinstance(_field_content.get('options'), list):
logs.append(f'{tab} -> {field} of type {field_type} expects a value of type list, '
f'but got {type(data[tab][field]["value"])}')
f'but got {type(_field_content.get("value")).__name__}')
Comment on lines +288 to +290

@coderabbitai coderabbitai Bot Jan 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Bug: Wrong variable used in error message for options type check.

Line 290 reports type(_field_content.get("value")) but the check on line 288 is validating _field_content.get('options'). The error message should reference options, not value.

🐛 Proposed fix 
                     if not isinstance(_field_content.get('options'), list):
                         logs.append(f'{tab} -> {field} of type {field_type} expects a value of type list, '
-                                    f'but got {type(_field_content.get("value")).__name__}')
+                                    f'but got {type(_field_content.get("options")).__name__}')
🤖 Prompt for AI Agents 
In @source/app/datamgmt/manage/manage_attribute_db.py around lines 288 - 290,
The error message inside the options type check uses the wrong variable; when
validating if not isinstance(_field_content.get('options'), list) update the
logs.append call in that branch to reference the actual options value (use
type(_field_content.get('options')).__name__) so the message reads that the
field expects a list but got the type of options, keeping the existing context
variables field and field_type.


for opt in data[tab][field].get('options'):
for opt in _field_content.get('options'):
if not isinstance(opt, str):
logs.append(f'{tab} -> {field} -> "options" expects a list of str, '
f'but got {type(opt)}')
f'but got {type(opt).__name__}')

elif field_type in ['raw', 'html']:
if _field_content.get('value') is None:
logs.append(f'{tab} -> {field} of type {field_type} is missing mandatory "value" tag')

elif field_type in ['raw', 'html']:
if data[tab][field].get('value') is None:
Expand Down