Handle comment-on-alert payloads in webhook dispatch#21
Open
Acsigen wants to merge 1 commit into
Open
Conversation
The 'alert' hook assumed data[0] was always an alert (object or dict) and ran it through AlertSchema. Comment-on-alert payloads are a dict carrying a nested 'alert' and a 'comment', which broke the schema dump and produced a bad object_url. Detect that shape via the 'comment' key: build object_url from the nested data[0]['alert']['alert_id'] and pass the raw payload through instead of dumping it with AlertSchema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'alert' hook assumed data[0] was always an alert (object or dict) and ran it through AlertSchema. Comment-on-alert payloads are a dict carrying a nested 'alert' and a 'comment', which broke the schema dump and produced a bad object_url.
Detect that shape via the 'comment' key: build object_url from the nested data[0]['alert']['alert_id'] and pass the raw payload through instead of dumping it with AlertSchema.