Skip to content

Retry Connection Fixes#37

Merged
ingalls merged 4 commits intomainfrom
retry
Mar 2, 2026
Merged

Retry Connection Fixes#37
ingalls merged 4 commits intomainfrom
retry

Conversation

@ingalls
Copy link
Member

@ingalls ingalls commented Mar 2, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the TAK TLS connection logic to avoid stale socket events interfering with reconnects, and bumps lint/coverage tooling versions.

Changes:

  • Guard TLS socket event handlers with a per-connection client reference to prevent old sockets from affecting new connections.
  • Emit a TAK-level 'close' event when the underlying socket closes without a preceding 'end', enabling retry logic.
  • Upgrade dev tooling dependencies (ESLint/c8) and update lockfile.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

File Description
index.ts Adds stale-socket guards for event handlers and emits a TAK-level 'close' event to support retries.
test/pipeline.test.ts Minor formatting/comment hunk change near the top of the test file.
package.json Upgrades devDependencies (notably ESLint/c8) and adds @eslint/js.
package-lock.json Lockfile updated to reflect the devDependency upgrades.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 5.55556% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
index.ts 5.55% 34 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ingalls ingalls merged commit cf0d5b9 into main Mar 2, 2026
4 of 5 checks passed
@ingalls ingalls deleted the retry branch March 2, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants