Conversation
There was a problem hiding this comment.
Pull request overview
Updates the TAK TLS connection logic to avoid stale socket events interfering with reconnects, and bumps lint/coverage tooling versions.
Changes:
- Guard TLS socket event handlers with a per-connection
clientreference to prevent old sockets from affecting new connections. - Emit a TAK-level
'close'event when the underlying socket closes without a preceding'end', enabling retry logic. - Upgrade dev tooling dependencies (ESLint/c8) and update lockfile.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
index.ts |
Adds stale-socket guards for event handlers and emits a TAK-level 'close' event to support retries. |
test/pipeline.test.ts |
Minor formatting/comment hunk change near the top of the test file. |
package.json |
Upgrades devDependencies (notably ESLint/c8) and adds @eslint/js. |
package-lock.json |
Lockfile updated to reflect the devDependency upgrades. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.