Conversation
This commit completes the technical documentation of the ADM1 implementation and its substrate modeling approach in PyADM1ODE. Key additions: - Documentation of the pure ODE approach with 37 state variables. - Description of the kinetic handling of acid-base equilibria (pH calculation from dynamic ion states). - Detailed explanation of agricultural substrate characterization via Weender and Van Soest analysis. - Integration of enhancements based on Koch et al. (2010), specifically the correction for hydrolysis in high-solids environments and the separate decay product Xp. - Updated mkdocs.yml for German and English navigation. The content was verified through an MkDocs build and checked for technical correctness against the provided reference materials. Co-authored-by: dgaida <23057824+dgaida@users.noreply.github.com>
This commit introduces a comprehensive technical documentation page for the ADM1 implementation and the agricultural substrate modeling approach. Key documentation points: - Switch from DAE to a pure ODE system with 37 state variables. - Kinetic handling of acid-base equilibria and gas-liquid transfer. - Explicit pH calculation from dynamic ion states (increased stability). - Substrate characterization using extended Weender and Van Soest analysis. - Integration of model enhancements from Koch et al. (2010), including the decay product Xp and the solids-dependent hydrolysis factor (noting that the latter is currently inactive in the code). - References to Gaida (2014) and Koch et al. (2010). Both German and English documentation files were added and integrated into the mkdocs navigation. Build verification passed. Co-authored-by: dgaida <23057824+dgaida@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.