fix: pass namespace when submitting login form with Enter#418
Open
shaunpatterson wants to merge 1 commit into
Open
fix: pass namespace when submitting login form with Enter#418shaunpatterson wants to merge 1 commit into
shaunpatterson wants to merge 1 commit into
Conversation
The form's onSubmit handler called onLogin(userid, password) without the namespace argument, so keyboard-submitted logins on multi-tenancy clusters dispatched loginIntoNamespace with Number(undefined) = NaN instead of the namespace typed into the form. The Login button already passed it correctly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line bug fix.
The login form's
onSubmithandler calledonLogin(userid, password)without the namespace argument, so submitting with Enter on a multi-tenancy cluster dispatchedloginIntoNamespacewithNumber(undefined)=NaNinstead of the namespace typed into the form. Clicking the Login button already passed it correctly — so the bug only bit keyboard users, which makes it confusing to reproduce.🤖 Generated with Claude Code