feat(homebridge-ring): expose Ring Alarm panel volume as a HomeKit slider (opt-in)#1653
Open
salmanesm wants to merge 3 commits into
Open
feat(homebridge-ring): expose Ring Alarm panel volume as a HomeKit slider (opt-in)#1653salmanesm wants to merge 3 commits into
salmanesm wants to merge 3 commits into
Conversation
…ider (opt-in) - Add VolumeAccessory mapping HomeKit Brightness (0–100) ↔ Ring volume (0.0–1.0) - Wire into discovery for devices that support setVolume() and have data.volume - Gate with config flag (no change unless enabled) - Use NodeNext-friendly .ts import paths; follow BaseDeviceAccessory pattern BREAKING CHANGE: none
-Update the README file
Owner
|
@salmanesm thanks for the PR. Could you walk me through your use case for adjusting the alarm volume? I generally try to avoid adding new options as they make maintenance and future changes harder. I'd also be cautious of adding this as a lightbulb as it makes certain siri commands more unpredictable (e.g. "turn off all the lights" will now slide your volume to zero 😬). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1652
Summary
Expose the Ring Alarm Base Station / Panel volume to HomeKit as a visible slider. This is opt-in and coexists with the existing Speaker/Volume characteristic.
Why
Implementation
VolumeAccessoryOn= volume > 0; turningOffsets volume to 0.device.onDatato keep HomeKit in sync.setVolume().ring-platform.ts, whenexposeAlarmVolumeis true, attachVolumeAccessoryfor devices that havedata.volumeandsetVolume().exposeAlarmVolume?: boolean(defaultfalse), and reservesvolumeService?: 'lightbulb' | 'speaker'for future use..tsextensions.Behavior
exposeAlarmVolumeis enabled.Config example
{ "platform": "Ring", "refreshToken": "<your-token>", "exposeAlarmVolume": true }