Skip to content

fix(ring-client-api): summarize ignored startup push notifications#1799

Open
tbaur wants to merge 1 commit into
dgreif:mainfrom
tbaur-contrib:fix/startup-push-notification-log-spam
Open

fix(ring-client-api): summarize ignored startup push notifications#1799
tbaur wants to merge 1 commit into
dgreif:mainfrom
tbaur-contrib:fix/startup-push-notification-log-spam

Conversation

@tbaur

@tbaur tbaur commented Jul 17, 2026

Copy link
Copy Markdown

Summary

  • During the intentional 2s startup push-ignore window, Ring often delivers dozens of queued notifications.
  • Each ignored notification was logged at info level, flooding Homebridge logs on every restart.
  • Count ignores and emit a single summary line after the window (e.g. Ignored 63 push notification(s)...).

Fixes #1800

Related: #1681 (closed as not planned when framed as a bug; this keeps the ignore behavior and only reduces log noise).

Test plan

  • npm run lint -w ring-client-api
  • npm run test -w ring-client-api
  • Restart homebridge-ring and confirm one summary line instead of many identical ignore messages

Log one summary after the startup ignore window instead of one info line per queued notification, which floods Homebridge logs on restart.
@changeset-bot

changeset-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1a96308

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
ring-client-api Patch
homebridge-ring Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tbaur

tbaur commented Jul 17, 2026

Copy link
Copy Markdown
Author

Opened tracking issue for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Summarize ignored startup push notifications instead of logging each one

1 participant