Skip to content

fix: visualization type positioning inside selector#3448

Merged
janhenrikoverland merged 2 commits intomasterfrom
fix/support-vis-type-sel-2-cols-DHIS2-16790
Mar 2, 2026
Merged

fix: visualization type positioning inside selector#3448
janhenrikoverland merged 2 commits intomasterfrom
fix/support-vis-type-sel-2-cols-DHIS2-16790

Conversation

@janhenrikoverland
Copy link
Collaborator

@janhenrikoverland janhenrikoverland commented Nov 19, 2025

Implements the final part of DHIS2-16790

Ref comment here: https://dhis2.atlassian.net/browse/DHIS2-16790?focusedCommentId=224670

Description

The css for visualization types in the selector was not agnostic to number of columns.

Fixed by using gap instead of margins.

Quality checklist

Add N/A to items that are not applicable.

Screenshots

Before:
Screenshot from 2025-11-19 15-06-15

After:
Screenshot from 2025-11-19 15-05-45

Screenshot from 2025-11-19 15-16-07

@sonarqubecloud
Copy link

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Nov 19, 2025

🚀 Deployed on https://pr-3448.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify November 19, 2025 14:12 Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

@dhis2-bot dhis2-bot temporarily deployed to netlify March 2, 2026 09:56 Inactive
@janhenrikoverland janhenrikoverland merged commit 3cfb176 into master Mar 2, 2026
50 of 53 checks passed
@janhenrikoverland janhenrikoverland deleted the fix/support-vis-type-sel-2-cols-DHIS2-16790 branch March 2, 2026 10:52
dhis2-bot added a commit that referenced this pull request Mar 2, 2026
## [101.4.1](v101.4.0...v101.4.1) (2026-03-02)

### Bug Fixes

* misaligned vis types in the selector ([#3448](#3448)) ([3cfb176](3cfb176))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants