Skip to content

refactor: Rename variables #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larshelge merged 1 commit into from
Apr 16, 2025
Merged

refactor: Rename variables #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/main/java/org/hisp/dhis/util/UidUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,20 +71,19 @@ public static boolean isValidUid(String code) {
/**
* Generates a pseudo random string with alphanumeric characters.
*
* @param codeSize the number of characters in the code.
* @param length the number of characters in the code.
* @return the code.
*/
public static String generateCode(int codeSize) {
ThreadLocalRandom r = ThreadLocalRandom.current();
public static String generateCode(int length) {
ThreadLocalRandom rand = ThreadLocalRandom.current();

char[] randomChars = new char[codeSize];
char[] randomChars = new char[length];

// First char should be a letter
// First char must be a letter
randomChars[0] = ALPHABET.charAt(rand.nextInt(ALPHABET.length()));

randomChars[0] = ALPHABET.charAt(r.nextInt(ALPHABET.length()));

for (int i = 1; i < codeSize; ++i) {
randomChars[i] = ALLOWED_CHARS.charAt(r.nextInt(CHAR_LENGTH));
for (int i = 1; i < length; ++i) {
randomChars[i] = ALLOWED_CHARS.charAt(rand.nextInt(CHAR_LENGTH));
}

return new String(randomChars);
Expand Down