fix(DHIS2-16608): enforce setting validators and reject invalid saves#1478
Open
Chisomchima wants to merge 2 commits intomasterfrom
Open
fix(DHIS2-16608): enforce setting validators and reject invalid saves#1478Chisomchima wants to merge 2 commits intomasterfrom
Chisomchima wants to merge 2 commits intomasterfrom
Conversation
Member
Chisomchima
commented
Apr 5, 2026
Chisomchima
commented
- Add shared buildValidatorsForMapping with min/max range checks
- Block saveKey when validation fails so bad values are not persisted
- Forward TextField onChange to FormBuilder for correct blur validation
- Add positive_number validator for credentialsExpiresReminderInDays
- Add shared buildValidatorsForMapping with min/max range checks - Block saveKey when validation fails so bad values are not persisted - Forward TextField onChange to FormBuilder for correct blur validation - Add positive_number validator for credentialsExpiresReminderInDays Made-with: Cursor
…HIS2-16608-settings-field-validation
|
Contributor
|
🚀 Deployed on https://pr-1478.settings.netlify.dhis2.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.