Add a wait mode that uses pidfd_open()#14
Merged
Merged
Conversation
To support new waiting methods that don't provide the exit code of the process being waited for, I'm changing the test script to recognize an environment variable PWAIT_SKIP_EXIT_CODE_TESTS, which if set to any nonempty value will cause the exit code tests to be skipped. Now that the main test function in the test script, run_all_tests(), supports skipping exit code tests, I changed the test configuration so that testing the poll method will use that function as well. The tests of the --delay option, which are specific to the polling method, will be run from a separate test function.
This is very similar to the implementation in the man page for pidfd_open (https://man7.org/linux/man-pages/man2/poll.2.html), but that's mostly because there isn't a lot of flexibility in how you can write code to do this.
This is necessary to have GitHub Actions workflows run after renaming the default branch from master to main.
This is necessary for GHA workflows to run on this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I'm adding a waiting mode based on
pidfd_open(). The implementation is similar to the one given in the man page for that function, but that's kind of forced by the task: there isn't a lot of flexibility in how you write this code.I also restructured the test script a bit to account for the fact that this is the second waiting mode that doesn't capture the exit code of the process being waited for.
Closes #4