Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
======================================
Coverage ? 0
======================================
Files ? 0
Lines ? 0
Branches ? 0
======================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
kmerDecoder migration
mr-eyes
commented
Jul 17, 2022
| kDataFrameSTL<MapType>::kDataFrameSTL(uint64_t ksize, uint64_t nKmers) { | ||
| this->class_name = "STL"; // Temporary until resolving #17 | ||
| this->kSize = ksize; | ||
| KD = new Kmers(kSize, TwoBits_hasher); |
Member
Author
There was a problem hiding this comment.
@shokrof Why is the TwoBits_hasher used here instead of integer hashing? TwoBits_hasher does not really hash the kmers, just returns the two-bit representation.
Member
Author
There was a problem hiding this comment.
Are you using here std::hash instead of the hashing modes in kmerDecoder?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.