Skip to content

Pulling feat/eslint-upgrade into develop#1009

Open
github-actions[bot] wants to merge 17 commits into
developfrom
feat/eslint-upgrade
Open

Pulling feat/eslint-upgrade into develop#1009
github-actions[bot] wants to merge 17 commits into
developfrom
feat/eslint-upgrade

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 14, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.76%. Comparing base (e8ab847) to head (f6c2d73).

Current head f6c2d73 differs from pull request most recent head 2a99426

Please upload reports for the commit 2a99426 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1009      +/-   ##
===========================================
- Coverage    92.54%   90.76%   -1.79%     
===========================================
  Files          417      360      -57     
  Lines        23582    20727    -2855     
  Branches      1162      941     -221     
===========================================
- Hits         21823    18812    -3011     
- Misses        1756     1912     +156     
  Partials         3        3              

see 92 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ktun95
Copy link
Copy Markdown
Collaborator

ktun95 commented Mar 14, 2025

Some eslint plugins have not been updated to be compatible with ESLint version 9

use https://eslint.org/blog/2024/05/eslint-compatibility-utilities/

ktun95 added 17 commits July 9, 2025 16:45
This commit introduces a custom ESLint configuration package
(`eslint-config-custom-9`) to enforce code style and quality
rules across the project. The package includes a rule to enforce
the use of semicolons and configures ESLint to apply to all
TypeScript files in the `src` directory.
The eslint-plugin-github plugin is added to provide GitHub-specific linting rules.
The tsconfig dependency is added to allow the eslint config to use the tsconfig.json file.
…or tsx files

Integrates eslint-plugin-github to enforce GitHub-specific linting rules and adds support for linting .tsx files. This ensures code adheres to GitHub's best practices and extends linting to React components.
Adds eslint plugins to improve code quality:
- eslint-plugin-prettier: integrates prettier with eslint
- eslint-plugin-sonarjs: detects bugs and code smells
- eslint-plugin-unicorn: enforces code style and best practices
…slint

This commit introduces several enhancements to the ESLint configuration:

-   Integrates `eslint-plugin-sonarjs` to enforce SonarJS coding standards,
    improving code quality and maintainability.
-   Adds `eslint-plugin-unicorn` with its recommended rules to promote
    consistent and modern JavaScript/TypeScript code.
-   Configures ESLint to properly lint TypeScript files (`.ts`, `.tsx`) by
    specifying the appropriate parser and settings. This includes setting
    the import parser and resolver to handle TypeScript-specific syntax and
    module resolution.
This commit updates various dependencies in the `yarn.lock` file.
The updates include both minor and patch version bumps for packages
such as `@eslint/*`, `browserslist`, `core-js-compat`,
`eslint-plugin-unicorn`, and many others.

The dependency updates are performed to ensure that the project is
using the latest versions of its dependencies, which may include bug
fixes, performance improvements, and new features. Updating
dependencies also helps to maintain compatibility with other
packages and tools in the ecosystem.
This commit updates the yarn.lock file to reflect changes in dependencies.
The yarn.lock file is updated to ensure that the project uses the correct
versions of dependencies.
This commit adds a new file named `eslint8-rules.json` to the repository.
This file contains the ESLint configuration rules for the project.
It includes various rules for JavaScript, TypeScript, React,
accessibility, and other code quality aspects.
The rules are configured to enforce code style, prevent errors,
and improve the overall maintainability of the codebase.

feat: add eslint9-rules.json file with eslint rules

This commit introduces a new file, `eslint9-rules.json`, which
contains the ESLint rules for the project. The rules are configured
to enforce code quality, consistency, and best practices. It also
includes configurations for typescript, react, import and unicorn
plugins.
The file also disables all stylistic rules as prettier is used for
formatting.
This commit introduces a new ESLint configuration file specifically
tailored for React applications. This configuration includes a set of
recommended rules and plugin configurations to enforce code quality,
best practices, and consistency in React projects.

The configuration includes plugins for React, import statements, JSX
accessibility, and React Hooks. It also defines a comprehensive set
of rules to catch potential errors, enforce code style, and improve
the overall maintainability of React applications.
This commit adds more eslint plugins and configs to the eslint config.
The added plugins are:
- @eslint/compat
- @eslint/eslintrc
- eslint-config-airbnb
- eslint-config-react-app
- eslint-plugin-compat
- eslint-plugin-import
- eslint-plugin-jsx-a11y
- eslint-plugin-react
- eslint-plugin-react-hooks
These plugins will help us to write more consistent and maintainable code.
Adds more plugins and configs to eslint, including:
- eslint-plugin-compat
- eslint-plugin-prettier/recommended
- reactApp config clone

This commit configures eslint with more plugins and configs to
improve code quality and consistency. The compat plugin helps
ensure that the code is compatible with different browsers.
The prettier plugin automatically formats the code. The reactApp
config clone provides a good starting point for linting React
applications.
…onfigs

This commit integrates the typescript eslint configuration and reorders the eslint configurations to ensure proper linting and formatting. The typescript config is now included for better typescript support. The order of configurations has been adjusted to ensure that the most important rules are applied first, and prettier is applied last to avoid conflicts.
Adds a new eslint configuration for typescript files.
This configuration includes the typescript eslint plugin and parser, and sets up rules specific to typescript.
It also disables some eslint rules that are already handled by the typescript compiler.

This change enables eslint to lint typescript files in the project.
The eslint config was not matching the correct name, so it was updated to match the correct name.
This change adds an ESLint configuration file to the dicty-frontpage application. This will help ensure code quality and consistency by enforcing coding standards. The configuration extends a custom ESLint configuration.
Adds declaration files for eslint plugins to prevent
typescript errors when importing eslint plugins.
@ktun95 ktun95 force-pushed the feat/eslint-upgrade branch from f6c2d73 to 2a99426 Compare July 9, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant