Pulling feat/editor-safety into develop#1032
Open
github-actions[bot] wants to merge 5 commits into
Open
Conversation
…navigation This adds a new hook that prevents the user from accidentally navigating away from the page. This can be useful for preventing data loss or other unexpected behavior.
…te content page This change adds a confirmation dialog when a user tries to navigate away from the create content page. This prevents accidental loss of unsaved changes. The `useConfirmNavigation` hook is used to achieve this functionality. The `useEffect` hook in `CreateContentForm` was removed and replaced with `useConfirmNavigation` hook in `CreateContentView` to handle the confirmation dialog.
…ation This change implements the `useConfirmNavigation` hook in both the `EditView.tsx` component of the `dicty-frontpage` app and the `EditView.tsx` component of the `stock-center` app. This hook prevents accidental navigation away from the edit view by displaying a confirmation dialog when the user attempts to leave the page with unsaved changes. This improves the user experience by preventing data loss.
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Adds documentation to the `useConfirmNavigation` hook to explain its purpose and functionality.
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 34ff1c3 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## develop #1032 +/- ##
========================================
Coverage 90.92% 90.92%
========================================
Files 373 373
Lines 21195 21195
Branches 985 980 -5
========================================
Hits 19271 19271
+ Misses 1923 1921 -2
- Partials 1 3 +2 🚀 New features to boost your workflow:
|
This commit introduces a new package, `@dictybase/draft-plugin`. This plugin provides functionality for automatically persisting drafts in the browser's local storage using the Lexical editor. It includes components for saving and retrieving drafts, utilizing `localforage` for storage management. The package also includes testing setup with `vitest` and necessary dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.