Skip to content

fix: replace broken SOP link and fix external links in HomepageColumn#1232

Draft
Copilot wants to merge 3 commits into
developfrom
copilot/fix-standard-operating-procedures-link
Draft

fix: replace broken SOP link and fix external links in HomepageColumn#1232
Copilot wants to merge 3 commits into
developfrom
copilot/fix-standard-operating-procedures-link

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 23, 2026

The Standard Operating Procedures navbar link was pointing to an expired Northwestern Box.com URL, and the GoldenBraid/GWDI home page links were broken because HomepageColumn routed all entries through React Router's Link, which can't handle external URLs.

Changes

SOP link update (all apps/packages)

Replaced broken https://northwestern.box.com/s/p0f8m70whgiuib2u0wt8gtn497ncmq8i with https://betastorage.dictybase.org/uploads/documents/DSC%20SOP.pdf across all 8 navbar config files and corresponding tests.

HomepageColumn — external link routing fix

Added an isExternalLink guard so external URLs render as <a> tags instead of React Router Link:

const isExternalLink = (to: string) =>
  to.startsWith("http://") || to.startsWith("https://")

// external → <a target="_blank" rel="noopener noreferrer">
// internal → <RouterLink to={to}>

This fixes the GoldenBraid list (docs.google.com/…) and GWDI catalog (remi-seq.org/…) links silently failing on click.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • betastorage.dictybase.org
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • dictycr.org
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • northwestern.app.box.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • northwestern.box.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue Apr 23, 2026 that may be closed by this pull request
19 tasks
… in HomepageColumn

Agent-Logs-Url: https://github.com/dictyBase/frontendx/sessions/7587ebfd-fb99-4887-a690-991d08fe99f6

Co-authored-by: cybersiddhu <48740+cybersiddhu@users.noreply.github.com>
@pull-request-size pull-request-size Bot added size/M and removed size/L labels Apr 23, 2026
Copilot AI changed the title [WIP] Fix broken Standard Operating Procedures link in navbar fix: replace broken SOP link and fix external links in HomepageColumn Apr 23, 2026
Copilot AI requested a review from cybersiddhu April 23, 2026 19:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.11%. Comparing base (df8993a) to head (5054eee).
⚠️ Report is 21 commits behind head on develop.

⚠️ Current head 5054eee differs from pull request most recent head b979c63

Please upload reports for the commit b979c63 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1232      +/-   ##
===========================================
- Coverage    94.54%   86.11%   -8.44%     
===========================================
  Files          417      441      +24     
  Lines        22026     3996   -18030     
  Branches      1502      447    -1055     
===========================================
- Hits         20825     3441   -17384     
+ Misses        1201      506     -695     
- Partials         0       49      +49     

see 442 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stock Center Report

2 participants