Pulling fix/strain-name-encoding into develop#1241
Open
github-actions[bot] wants to merge 3 commits into
Open
Conversation
This change adds read functions to decode URI-encoded fields (label, summary, genes, genotypes) in the Strain cache data, ensuring proper display of special characters.
This commit introduces a new function, `decodeUriComponentOrDefault`, which attempts to decode a URI component. If decoding fails due to a URIError, the function returns the original URI component. This ensures that the application gracefully handles potentially malformed URI components without throwing errors. The function uses fp-ts for functional error handling.
This change ensures that strain labels, summaries, gene names, and genotypes are properly decoded before being displayed, handling URI encoded components. A new utility function `decodeUriComponentOrDefault` was added to handle decoding and prevent errors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1241 +/- ##
===========================================
- Coverage 94.54% 86.10% -8.44%
===========================================
Files 417 441 +24
Lines 22026 3995 -18031
Branches 1502 443 -1059
===========================================
- Hits 20825 3440 -17385
+ Misses 1201 506 -695
- Partials 0 49 +49 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.