Pulling feat/lighthouse-ci into develop#1265
Open
github-actions[bot] wants to merge 11 commits into
Open
Conversation
This change adds a lighthouserc.json file to configure Lighthouse CI. The configuration specifies the URL to test, the command to start the server, and the upload target.
…ite configs The preview configuration is added to ensure consistent port settings during preview mode, mirroring the behavior of the server configuration. This change ensures that the application uses the specified port and enforces strict port usage during preview, preventing potential conflicts.
The vite preview command is now configured to use the default port, which simplifies the configuration and allows vite to handle port allocation automatically.
Collaborator
|
https://github.com/treosh/lighthouse-ci-action Might be simpler to use |
This commit introduces a Lighthouse configuration file (`.lighthouserc.json`) to enable performance testing in the CI environment. The configuration specifies the URL to test, the command to start the server, a pattern to wait for before starting tests, and assertion rules based on Lighthouse recommendations. It also configures the test results to be saved to the filesystem.
The Lighthouse CI workflow is added to the build process to automatically run performance audits on every pull request. This helps to catch performance regressions early and ensures that the application maintains a high level of performance.
The Lighthouse CI autorun command now includes the working directory and configuration path, ensuring that the Lighthouse CI runs correctly in the dfp directory with the correct configuration file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1265 +/- ##
===========================================
- Coverage 94.54% 86.37% -8.18%
===========================================
Files 417 449 +32
Lines 22026 4052 -17974
Branches 1502 446 -1056
===========================================
- Hits 20825 3500 -17325
+ Misses 1201 503 -698
- Partials 0 49 +49 🚀 New features to boost your workflow:
|
The lighthouse autorun command requires a github token to be able to post the results to github. This commit adds the github token to the command.
The Lighthouse configuration is updated to utilize temporary public storage for reports, which simplifies sharing and accessibility of the generated reports.
The lighthouserc.json file is no longer needed, so it has been removed.
The .lighthouseci folder is added to .gitignore to prevent local Lighthouse CI reports from being committed to the repository.
The githubToken was removed from the lhci autorun command and instead passed as an environment variable. This change was made to resolve an error where the token was not being properly passed to the lhci autorun command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On running against mobile and desktop
GoogleChrome/lighthouse-ci#138 (comment)