Pulling fix/carousel-images-from-develop into develop#1269
Merged
Conversation
static-server only serves real files under /assets (its --sf flag) and falls back to index.html for everything else, so the carousel images placed at /carousel/* in public/ would 404 in production. Move them back into packages/ui-frontpage/src/assets/carousel and import them so Vite emits them as hashed /assets/* files that static-server serves. The AVIF/WebP <picture> sources, intrinsic width/height, and first-slide fetchpriority/eager loading are retained. Drop the index.html <link rel="preload"> for the first slide: imported assets get hashed filenames with no stable path to preload statically, and it pointed at the now-removed /carousel path. fetchpriority="high" on the eager first slide keeps the LCP prioritization. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The documentation is updated to include instructions on how to verify changes that affect the build process. This ensures that build-related changes are thoroughly tested before deployment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1269 +/- ##
===========================================
- Coverage 94.54% 86.24% -8.31%
===========================================
Files 417 456 +39
Lines 22026 4136 -17890
Branches 1502 448 -1054
===========================================
- Hits 20825 3567 -17258
+ Misses 1201 520 -681
- Partials 0 49 +49
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.