refactor: reorganize source layout to match modware-import conventions#31
Merged
Conversation
…l/arangodb/cli package
… internal packages Also anchor /arangoadmin in .gitignore to the root binary only, so cmd/arangoadmin/ directory is not ignored.
…dlers All three CLI actions (EnsureUser, EnsureDatabase, EnsureGrant) now log outside the pipeline using LogEnsureXxxOutcome after the fold, consistent with each other. Removed IOK wrapper functions from logger.go.
Each handler's error and success fold functions are now package-level vars defined via F.Bind1st/F.Bind2nd, eliminating explicit argument names from the E.Fold call sites.
…rt ordering Enabled gci, gofmt, gofumpt, goimports, golines formatters. gci sections: standard → external → internal (dictybase-docker prefix). Applied golangci-lint fmt to fix import grouping across all files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package mainroot intocmd/+internal/tree matching modware-import structurecmd/arangoadmin/main.go— binary entrypointinternal/logger/—NewLogger/ParseLogLevelutilitiesinternal/arangodb/— domain logic (types, connection, user, database, grant) + unit testsinternal/arangodb/cli/— CLI command definitions and action functions + integration testsEnsureUser,EnsureDatabase,EnsureGrant) log outside the pipeline via exported outcome functionsE.Foldbranches extracted as point-free standalonevars usingF.Bind1st/F.Bind2nd.golangci.yml(gci, gofmt, gofumpt, goimports, golines with chain-split-dots)Test plan
go build ./...passesgolangci-lint run ./...passes with 0 issuesgolangci-lint fmt ./...produces no diffgotestsum --format dots)🤖 Generated with Claude Code