Skip to content

Include error messages from server in output #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patkec wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include error messages from server in output #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ FlowStatusWebpackPlugin.prototype.apply = function(compiler) {
waitingForFlow = true;

// this will start a flow server if it was not running
shell.exec(flow + ' status --color always', {silent: true}, function(code, stdout, stderr) {
// quiet option will suppress any "server starting" messages
shell.exec(flow + ' status --color always --quiet', {silent: true}, function(code, stdout, stderr) {
var hasErrors = code !== 0;
var cb = hasErrors ? errorCb : successCb;
waitingForFlow = false;
Expand All @@ -59,10 +60,19 @@ FlowStatusWebpackPlugin.prototype.apply = function(compiler) {
onSuccess(stdout);

cb();
}, function error(stdout) {
onError(stdout);
}, function error(stdout, stderr) {
var msg = stdout;
// In case flow server got killed.
if (!stdout && !stderr) {
stderr = 'Unknown error!';
}
if (stderr) {
msg = (msg ? msg + '\n' : '') + 'flow server: ' + stderr;
}

flowError = new Error(stdout);
onError(msg);

flowError = new Error(msg);
// Here we don't pass error to callback because
// webpack-dev-middleware would just throw it
// and cause webpack dev server to exit with
Expand Down