Add AMD (Require.js) + CommonJS (browserify) wrapper#104
Closed
thibaudcolas wants to merge 3 commits intodieulot:masterfrom
Closed
Add AMD (Require.js) + CommonJS (browserify) wrapper#104thibaudcolas wants to merge 3 commits intodieulot:masterfrom
thibaudcolas wants to merge 3 commits intodieulot:masterfrom
Conversation
Owner
|
Thanks for this. Currently I’m focused on getting InstantClick out of its hiatus (= shipping InstantClick 3.1), I’ll take a deeper look at this once the project is moving again. |
Owner
Author
|
Hey there, no worries, it's already cool that you took some time to look at it. I answered in #63 and I'll stop here. Take care. |
|
Just FYI, I built a UMD version of this library two years ago for you to use in a modern bundler: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
here's a PR to add support for two module loaders: Require.js (AMD modules,
define) and browserify (Node-ish/CommonJS,module.exports). It should help with the following issues: #63 and #73.The UMD wrapper is taken from https://github.com/eduardolundgren/gulp-umd (see also https://github.com/umdjs/umd). I changed it a little bit to accomodate the following browserify issue (use
window || thisfor root instead ofthis).The AMD / Require.js scenario is fully working, and I added a test case for it (http://127.0.0.1:8000/tests/?amd=1).
The CommonJS / browserify story is a little different. It's also fully working, but there are caveats:
package.json, and if possible publishing it on the npm repository. After that, users will be able torequire('instantclick')instead ofrequire('../../vendor/instantclick-x.x.x/instantclick').Let me know if it suits you!