Load scripts synchronously

[Kronuz]

External scripts were being asynchronously loaded as part of the new page being loaded. This could break inlined scripts that depended on such scripts.

Example:

<script src="http://example.com/external_methods.js"></script>
<script>external_method();</script>

This pull request fixes this problem by waiting for scripts to load before inserting the remaining script elements.

[yazeed]

Please merge this, it's very critical.

[CoolOppo]

@dieulot Why haven't you commented on this yet? You added the "Bug" label 12 days ago, and it seems like you may not have realized that this is a pull request.

[dieulot]

I did notice that, but I haven’t had time to look into it. Don’t fret, I’m just a bit overwhelmed by all there is to do with InstantClick’s development at the moment.

[CoolOppo]

Alright, no problem. I was just commenting to make sure because it seemed to me like you may not have noticed. I didn't want that to come off in a negative manner.

[dogweather]

👍

[franciscop]

As a temporary fix to anyone suffering this: load all scripts on all pages (if different <script> tags are being used).

Reproduction:

<!-- page1.html -->
<script src="fna.js"></script>
<script>fna();</script>

<!-- page2.html -->
<!-- no fna.js -->
<!-- no fna() -->

Go to page2.html, then click a link that takes you to page1.html. The second script is faster since the first one has to load from a remote server. So the above configuration will throw the error ReferenceError: fna is not defined.

Now, to fix it, do this:

<!-- page1.html -->
<script src="fna.js"></script>
<script>fna();</script>

<!-- page2.html -->
<script src="fna.js"></script>
<!-- no fna() -->

@dieulot would you consider other maintainers? At least for bugfixing/accepting PR. This project is very cool but it's a pity that it has some unresolved bugs.